Add screenReaderText, Fix XTerm.js crash, Improve console log messages #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the avalanche of > Th: Table headers must have an accessible name. If the Th is intended to be visually empty, pass in screenReaderText. If the Th contains only non-text, interactive content such as a checkbox or expand toggle, pass in an aria-label. console messages, which completely drown any actually useful messages for debugging.
During terminal initialization, the `_renderService` or its `.dimensions` attribute may not yet be defined. Exit the resizing function in this case instead of crashing with a `TypeError`. Add a reference to the upstream issue about this internal API hackery.
martinpitt
changed the title
martinpitt
changed the title
1 task
cockpituous
reviewed
Jan 26, 2025
| @@ -80,11 +80,14 @@ class ContainerLogs extends React.Component { | |||
| } | |||
|
|
|||
| resize(width) { | |||
| if (!this.term?._core?._renderService?.dimensions) | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+203
to
+204
| .catch(e => console.warn("initContainers", system ? "system" : "user", | ||
| "getContainers failed:", e.toString())); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
1 task
jelly
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixups that I split out from #1976.
See this log for the
dimensionscrash: