-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: Stop hardcoding 2048 bit RSA key length #21606
Conversation
These are rejected as "too weak" by the "FUTURE" crypto policy. Let the tools decide about appropriate defaults rather. Thanks to Renaud Métrich for finding this! https://issues.redhat.com/browse/RHEL-78645
I tested this command:
and then checked the key length. On Debian 12 (our oldest supported release), Fedora 41, and even RHEL 8.10. The default already is 2048 bits, so for the default crypto policy there is no change. |
The f41/revdeps failure is unrelated and tracked in cockpit-project/cockpit-podman#1999 https://artifacts.dev.testing-farm.io/2386b322-90d8-4923-831d-981d7481306d/ |
@@ -30,7 +30,6 @@ install_key() { | |||
selfsign_sscg() { | |||
sscg --quiet \ | |||
--lifetime "${DAYS}" \ | |||
--key-strength 2048 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As not all distros have crypto policies, I looked at the default for key-strength, its 2048 for sscg
@@ -43,7 +42,7 @@ selfsign_sscg() { | |||
selfsign_openssl() { | |||
openssl req -x509 \ | |||
-days "${DAYS}" \ | |||
-newkey rsa:2048 \ | |||
-newkey rsa \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the man page also defaults to 2028
These are rejected as "too weak" by the "FUTURE" crypto policy. Let the tools decide about appropriate defaults rather.
Thanks to Renaud Métrich for finding this!
https://issues.redhat.com/browse/RHEL-78645