Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: Stop hardcoding 2048 bit RSA key length #21606

Merged
merged 1 commit into from
Feb 11, 2025
+1 −2
Merged

tls: Stop hardcoding 2048 bit RSA key length #21606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/tls/cockpit-certificate-helper.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ install_key() {
selfsign_sscg() {
sscg --quiet \
--lifetime "${DAYS}" \
--key-strength 2048 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As not all distros have crypto policies, I looked at the default for key-strength, its 2048 for sscg

--cert-key-file "${KEYFILE}" \
--cert-file "${CERTFILE}" \
--ca-file "${CA_FILE}" \
Expand All @@ -43,7 +42,7 @@ selfsign_sscg() {
selfsign_openssl() {
openssl req -x509 \
-days "${DAYS}" \
-newkey rsa:2048 \
-newkey rsa \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the man page also defaults to 2028

-keyout "${KEYFILE}" \
-keyform PEM \
-nodes \
Expand Down
Loading