cli: harden debug sb recreate a bit#147803
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 4, 2025
Merged
Conversation
yuzefovich
added
the
backport-all
yuzefovich
requested review from
alyshanjahani-crl
and removed request for
a team
Member
|
This change is |
This commit ensures that `debug sb recreate` command works on a statement bundle that has "default_transaction_use_follower_reads" session variable set (by resetting to the default). (A recent support bundle was failing recreation with a cryptic "resolved system to 1 but found no descriptor with id 1" error.) Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
DrewKimball
approved these changes
Jun 4, 2025
Collaborator
DrewKimball
left a comment
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Member
Author
|
TFTR! bors r+ |
Contributor
This was referenced Jun 4, 2025
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures that
debug sb recreatecommand works on a statement bundle that has "default_transaction_use_follower_reads" session variable set (by resetting to the default). (A recent support bundle was failing recreation with a cryptic "resolved system to 1 but found no descriptor with id 1" error.)Informs: https://github.com/cockroachlabs/support/issues/3317.
Epic: None
Release note: None