Set locale via LC_ALL when using cqsh or qsh
#2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanjula Ganepola <[email protected]>
SanjulaGanepola
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Signed-off-by: Sanjula Ganepola <[email protected]>
SanjulaGanepola
changed the title
LC_ALL even when using cqshLC_ALL even when using cqsh or qsh
SanjulaGanepola
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
SanjulaGanepola
changed the title
LC_ALL even when using cqsh or qshLC_ALL when using cqsh or qsh
|
Looks like the tests are passing for me: 
|
|
There is a chance this bug will fix #2519, and this is where the bug was introduced: 84d21dd#diff-af91aaa8436f73c4457121b35da47e46d53459b47f044b7dbdb78ea785cb1824R1449 |
worksofliam
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2531 by setting
LC_ALLwhen usingcqshorqsh.How to test this PR
Run the test suite or query for objects in the Object Browser that contain NL chars such as in #2531
Checklist