Conversation
…sn't exist and cc-downloader downloaded the body of the response Now this action will produce an error
…the 4XX error message when downloading paths, adds validation to the cli input for the crawl reference
… automatically fix the casing of the crawl reference
CC-NEWS support and validation for crawl reference
…d files and updated the README.md in order to prepare the next release
This was
linked to
issues
Mar 7, 2025
Closed
Member
Author
|
@thunderpoot, don't accept or review the PR yet, the
I think it is going to get fixed soon: But this is indeed a problem. I'm thinking of including the
|
… the reqwest deprecated API TODO: We need to monitor the the open PRs in reqwest-middleware and bump the version of it here as soon as they are merged
Member
Author
|
@thunderpoot It should be safe to review now. I'll track the PR on |
thunderpoot
approved these changes
Mar 17, 2025
Member
thunderpoot
left a comment
thunderpoot
left a comment
There was a problem hiding this comment.
This is great. Nice error messaging, and fantastic that it supports my laziness (not typing CC-MAIN or CC-NEWS in all caps). Approved 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for CC-NEWS and adds validations for the crawl or snapshot references. This PR also updates some libraries and bumps the rust edition to 2024 and the latest 1.85 version. It also bumps the library version to
0.6.0.Breaking Changes
No Breaking changes
Notes & open questions
This PR closes issues #8 and #10.