Skip to content

Add tinkr#29751

Merged
mfansler merged 1 commit intoconda-forge:mainfrom
matthewfeickert:feat/add-tinkr
Apr 26, 2025
Merged

Add tinkr#29751
mfansler merged 1 commit intoconda-forge:mainfrom
matthewfeickert:feat/add-tinkr

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 17, 2025

Resolves #29749

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/r-tinkr/recipe.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: zkamvar. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Apr 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-tinkr/meta.yaml) and found it was in an excellent condition.

extra:
recipe-maintainers:
- matthewfeickert
- zkamvar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkamvar if you'd be willing to be a feedstock maintainer for tinkr (c.f. ropensci/tinkr#133) can you please comment on the PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what it means to be a feedstock maintainer in this context. What does it involve? Do I need to do anything extra when I make a new {tinkr} release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it involve? Do I need to do anything extra when I make a new {tinkr} release?

@zkamvar The short answer is not much, given that R packages that don't have much build complexity are straightforward. The way that conda-forge works is lots of automation, so anytime that you make a new release to CRAN within 24 hours the autotick-bot will automatically open up a new PR that migrates the feedstock (a feedstock is a repository that has a build recipe in it. Example: https://github.com/conda-forge/r-markdown-feedstock) to the new version. Maintainers review these automated PRs and then adjust them if there were things like dependency changes or something like that that needed the build to be altered to be passing. Here's an example PR where there was a little bit of additional action needed (waiting for a new dependency to get added to conda-forge): conda-forge/r-markdown-feedstock#29

In some sense this is similar to CRAN (I think, I'm a Python and C++ person, so I don't actually maintain any R packages) where (I think) the system does build automation. The difference (I think) here is that conda-forge has more robust multi-platform build support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkamvar I've removed you from the maintainers list, as this would need your approval to move forward, but if you'd like to be added once this gets merged it would be great to have you on there.


build:
number: 0
merge_build_and_host_envs: true
Copy link
Member Author

@matthewfeickert matthewfeickert Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In conda-build syntax this used to be merge_build_host which for rattler-build is merge_build_and_host_envs. c.f. https://github.com/conda/ceps/blob/main/cep-0014.md#build-section

@matthewfeickert matthewfeickert marked this pull request as ready for review April 17, 2025 07:04
@matthewfeickert matthewfeickert force-pushed the feat/add-tinkr branch 2 times, most recently from e503cb0 to 622cbef Compare April 17, 2025 23:26
@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@matthewfeickert matthewfeickert force-pushed the feat/add-tinkr branch 2 times, most recently from 4fa527d to 2eaa50d Compare April 20, 2025 04:58
@matthewfeickert matthewfeickert requested a review from zkamvar April 20, 2025 04:58
@matthewfeickert matthewfeickert force-pushed the feat/add-tinkr branch 2 times, most recently from 5751559 to 7007a23 Compare April 22, 2025 04:09
Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resubmit a (schema 0) recipe generated from conda_r_skeleton_helper.

@matthewfeickert
Copy link
Member Author

@mfansler thanks for the info, but why v0 and not v1? (I'm in transit today so will get to this when I have laptop access again).

@mfansler
Copy link
Member

mfansler commented Apr 23, 2025

@mfansler thanks for the info, but why v0 and not v1? (I'm in transit today so will get to this when I have laptop access again).

The Conda Forge R team has maintained a v0 recipe standard - implemented in conda_r_skeleton_helper - for nearly all R recipes. We haven't yet established the translation to v1, in part because rattler-build still lacks functionality that we depend on (see conda-forge/conda-forge.github.io#2308). So, until we nail that down, it would be better to continue with v0 and let us automate v0 -> v1 conversion later. That helps us ensure consistent patterns and makes our future migrations smoother.

@matthewfeickert
Copy link
Member Author

So, until we nail that down, it would be better to continue with v0 and let us automate v0 -> v1 conversion later. That helps us ensure consistent patterns and makes our future migrations smoother.

Thanks for the info @mfansler. It would be great if bgruening/conda_r_skeleton_helper#58 could get moved forward until then as well. I appreciate that the scripts that are used are correct, and so useful, but not having a CLI utility that can be installed and having to manually edit a package list is a bit of friction that ideally could be moved to a pixi exec command.

@matthewfeickert
Copy link
Member Author

@conda-forge/help-r, ready for review!

Comment on lines +69 to +72
extra:
recipe-maintainers:
- conda-forge/r
- matthewfeickert
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfansler mfansler merged commit 374b206 into conda-forge:main Apr 26, 2025
7 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-tinkr branch April 26, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: tinkr

4 participants