Conversation
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/r-tinkr/recipe.yaml
Outdated
| extra: | ||
| recipe-maintainers: | ||
| - matthewfeickert | ||
| - zkamvar |
There was a problem hiding this comment.
@zkamvar if you'd be willing to be a feedstock maintainer for tinkr (c.f. ropensci/tinkr#133) can you please comment on the PR?
There was a problem hiding this comment.
I'm not exactly sure what it means to be a feedstock maintainer in this context. What does it involve? Do I need to do anything extra when I make a new {tinkr} release?
There was a problem hiding this comment.
What does it involve? Do I need to do anything extra when I make a new {tinkr} release?
@zkamvar The short answer is not much, given that R packages that don't have much build complexity are straightforward. The way that conda-forge works is lots of automation, so anytime that you make a new release to CRAN within 24 hours the autotick-bot will automatically open up a new PR that migrates the feedstock (a feedstock is a repository that has a build recipe in it. Example: https://github.com/conda-forge/r-markdown-feedstock) to the new version. Maintainers review these automated PRs and then adjust them if there were things like dependency changes or something like that that needed the build to be altered to be passing. Here's an example PR where there was a little bit of additional action needed (waiting for a new dependency to get added to conda-forge): conda-forge/r-markdown-feedstock#29
In some sense this is similar to CRAN (I think, I'm a Python and C++ person, so I don't actually maintain any R packages) where (I think) the system does build automation. The difference (I think) here is that conda-forge has more robust multi-platform build support.
There was a problem hiding this comment.
@zkamvar I've removed you from the maintainers list, as this would need your approval to move forward, but if you'd like to be added once this gets merged it would be great to have you on there.
10df092 to
d0308e2
Compare
recipes/r-tinkr/recipe.yaml
Outdated
|
|
||
| build: | ||
| number: 0 | ||
| merge_build_and_host_envs: true |
There was a problem hiding this comment.
In conda-build syntax this used to be merge_build_host which for rattler-build is merge_build_and_host_envs. c.f. https://github.com/conda/ceps/blob/main/cep-0014.md#build-section
e503cb0 to
622cbef
Compare
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
4fa527d to
2eaa50d
Compare
5751559 to
7007a23
Compare
mfansler
left a comment
There was a problem hiding this comment.
Please resubmit a (schema 0) recipe generated from conda_r_skeleton_helper.
|
@mfansler thanks for the info, but why v0 and not v1? (I'm in transit today so will get to this when I have laptop access again). |
The Conda Forge R team has maintained a v0 recipe standard - implemented in |
* Add the tinkr R package. - c.f. https://github.com/ropensci/tinkr/ - Generated using https://github.com/bgruening/conda_r_skeleton_helper.
7007a23 to
2781e1c
Compare
Thanks for the info @mfansler. It would be great if bgruening/conda_r_skeleton_helper#58 could get moved forward until then as well. I appreciate that the scripts that are used are correct, and so useful, but not having a CLI utility that can be installed and having to manually edit a package list is a bit of friction that ideally could be moved to a |
|
@conda-forge/help-r, ready for review! |
| extra: | ||
| recipe-maintainers: | ||
| - conda-forge/r | ||
| - matthewfeickert |
Resolves #29749
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).