Skip to content

⬆️ Upgrade PHP dependency to support PHP8 installation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Th3Mouk
Copy link

@Th3Mouk Th3Mouk commented Jul 23, 2020

The release of PHP8 alpha approaching, it will be nice if the lib authorize installation without tweaking composer installation.

Release 3.10.2 is needed too along the merge

@Th3Mouk
Copy link
Author

Th3Mouk commented Sep 26, 2020

@VasekPurchart Is there anything more I can do to help you?

@OndraM
Copy link

OndraM commented Nov 25, 2020

🙏 @VasekPurchart Could you have a look? This seems to be dependency of dependency of one of our dependencies 🙃 . Let us know if we can provide any help to get this merged and released 👍 .

mhujer added a commit to ahilles107/jms-serializer-uuid that referenced this pull request Dec 31, 2020
mhujer added a commit to mhujer/jms-serializer-uuid-bundle that referenced this pull request Dec 31, 2020
PHP 8.0 is allowed to fail because consistence/coding-standard does not support it yet

See consistence/coding-standard#65
@TomasVotruba
Copy link

Yet another from phpstan: phpstan/phpdoc-parser#57

I'd appreciate this to be merged to allow coding stadnard on PHP 8

farabidev pushed a commit to farabidev/coding-standard that referenced this pull request Feb 11, 2021
The update is replicated from 
consistence#65
@mhujer
Copy link
Contributor

mhujer commented Mar 6, 2021

Hello @Th3Mouk @OndraM @TomasVotruba,

I'm using Consistence libraries on several projects, so I decided to fork them and maintain them under consistence-community namespace.

You can find the coding-standard library here: https://github.com/consistence-community/coding-standard

The consistence-community packages should be drop-in replacements while supporting newer PHP/Symfony versions. It should be enough to replace consistence/ with consistence-community/ in the composer.json (along with the version constraint) and run composer update.

@TomasVotruba
Copy link

@mhujer Thank you Martin, that's amazing news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants