feat: adding filter infrastructure + status and event filter #3247
Conversation
CodeChanning
force-pushed
the
events_filter
branch
6 times, most recently
from
c087896 to
7a2a1f2
Compare
|
@AkihiroSuda PTAL when you get the chance |
| @@ -1276,7 +1276,7 @@ Flags: | |||
|
|
|||
| - :whale: `--format`: Format the output using the given Go template, e.g, `{{json .}}` | |||
There was a problem hiding this comment.
The new flag docs can be added here. :-)
There was a problem hiding this comment.
Added events --filter docs. PTAL and let me know if this is sufficient. @yankay
pkg/cmd/system/events.go
Outdated
| // EventFilter for filtering events | ||
| type EventFilter func(*EventOut) bool | ||
|
|
||
| // Similar to podman implementation: |
There was a problem hiding this comment.
In Golang, usually, the comments should start with the Function Name. When documenting a function, the first sentence should typically start with the function's name. This format helps quickly clarify the function’s purpose.
There was a problem hiding this comment.
I changed the comments. Let me know if that works.
Signed-off-by: CodeChanning <[email protected]>
CodeChanning
force-pushed
the
events_filter
branch
from
7a2a1f2 to
0721f44
Compare
|
@AkihiroSuda |
|
|
||
| isDocker := testutil.GetTarget() == testutil.Docker | ||
| if isDocker && tc.dockerSkip { | ||
| t.Skip("test is incompatible with Docker") |
There was a problem hiding this comment.
Could you add a comment to explain the reason?
I guess this is safe to cherry-pick. Feel free to open cherry-pick PRs after merging to the main branch. |
Implementing
--filterflag fornerdctl events, Addresses part of #54This change adds infrastructure for adding filters. Similar to Podman's implementation of
--filter.I also added Status and Event filter and unit tests for those.
Context: