Skip to content
/ messenger Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of Contributte DI (Closes #10) #13

Merged
merged 1 commit into from
Feb 14, 2024
+1 −1
Merged

Drop usage of Contributte DI (Closes #10) #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
Drop usage of Contributte DI (Closes #10)
@finwe
finwe committed Feb 13, 2024

Verified

This commit was signed with the committer’s verified signature.
finwe Matěj Humpál
GPG key ID: 7BEF289A1ADEDC4D
Verified
Learn about vigilant mode
commit e3ce8116bd8af9e8e1f6f123f9d22c20eb2687c8
2 changes: 1 addition & 1 deletion src/DI/MessengerExtension.php
View file
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@

namespace Contributte\Messenger\DI;

use Contributte\DI\Extension\CompilerExtension;
use Contributte\Messenger\DI\Pass\AbstractPass;
use Contributte\Messenger\DI\Pass\BusPass;
use Contributte\Messenger\DI\Pass\ConsolePass;
@@ -15,6 +14,7 @@
use Contributte\Messenger\DI\Pass\TransportFactoryPass;
use Contributte\Messenger\DI\Pass\TransportPass;
use Nette\DI\Definitions\Statement;
use Nette\DI\CompilerExtension;

Check failure on line 17 in src/DI/MessengerExtension.php

GitHub Actions / Codesniffer / Codesniffer (8.1) 

Use statements should be sorted alphabetically. The first wrong one is Nette\DI\CompilerExtension.
use Nette\PhpGenerator\ClassType;
use Nette\Schema\Expect;
use Nette\Schema\Schema;

Unchanged files with check annotations Beta

View file
src/DI/Utils/Reflector.php
throw new LogicalException(sprintf('Handler must have "%s::%s()" method.', $class, $options['method']));
}
if ($rcMethod->getNumberOfParameters() !== 1 && !$rc->implementsInterface( BatchHandlerInterface::class)) {

Check failure on line 69 in src/DI/Utils/Reflector.php

GitHub Actions / Codesniffer / Codesniffer (8.1) 

Space after opening parenthesis of function call prohibited
throw new LogicalException(sprintf('Only one parameter is allowed in "%s::%s()."', $class, $options['method']));
}
if ($rc->implementsInterface( BatchHandlerInterface::class)) {

Check failure on line 73 in src/DI/Utils/Reflector.php

GitHub Actions / Codesniffer / Codesniffer (8.1) 

Space after opening parenthesis of function call prohibited
if ($rcMethod->getNumberOfParameters() !== 2) {
throw new LogicalException(sprintf('Exactly two parameters are required in "%s::%s()."', $class, $options['method']));
}