Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): fix synchronization between slider inner and props values #1573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Haskiro
Copy link
Contributor

@Haskiro Haskiro commented Feb 11, 2025

Опишите проблему

Плохая связанность между значениями из пропс и внутри слайдера. Если мы например не меняем value снаружи в onChange, то value будет правильным, а позиция бегунка слайдера будет смещена

Шаги для воспроизведения

  1. Убираем обработчик onChange, либо блокируем изменение value из него
  2. Двигаем ползунком

Ожидаемое поведение

После изменений value и позиция ползунка должны совпадать

Дополнительная информация

Ссылка на задачу

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 4a0ce69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@alfalab/core-components-select Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13259932446

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.343%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/slider/src/Component.tsx 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
packages/slider/src/Component.tsx 1 69.61%
Totals Coverage Status
Change from base Build 13259324563: -0.01%
Covered Lines: 10817
Relevant Lines: 11987

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants