Implementing Parquet Converter #6716
Open
+344,990
−3,633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
parquet-converter
branch
from
b0c7c06 to
2eec8b9
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
parquet-converter
branch
3 times, most recently
from
57efb1c to
5e75bc8
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
parquet-converter
branch
from
5e75bc8 to
d820fd5
Compare
yeya24
reviewed
Apr 24, 2025
yeya24
reviewed
Apr 24, 2025
| ) | ||
|
|
||
| type CompactionMark struct { | ||
| Version int `json:"version"` |
There was a problem hiding this comment.
Maybe we can add a comment about what this version actually means. It is the same as the version of the parquet file schema and updating version will trigger a rewrite of the parquet file?
yeya24
reviewed
Apr 24, 2025
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
parquet-converter
branch
2 times, most recently
from
01a64a4 to
2497df1
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
parquet-converter
branch
from
2497df1 to
46e3114
Compare
alanprot
force-pushed
the
parquet-converter
branch
4 times, most recently
from
3d72c44 to
cc6d121
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
parquet-converter
branch
from
cc6d121 to
4fa4df6
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
parquet-converter
branch
from
fa8300a to
1c8eda0
Compare
yeya24
reviewed
Apr 27, 2025
| @@ -113,6 +114,7 @@ type Config struct { | |||
| QueryRange queryrange.Config `yaml:"query_range"` | |||
| BlocksStorage tsdb.BlocksStorageConfig `yaml:"blocks_storage"` | |||
| Compactor compactor.Config `yaml:"compactor"` | |||
| ParquetConverter parquetconverter.Config `yaml:"parquet_converter" doc:"hidden"` | |||
There was a problem hiding this comment.
Do we usually mark a new component config as hidden?
Should we still add parquet storage feature as experimental in v1 guarantee?
|
|
||
| const ( | ||
| ConverterMarkerFileName = "parquet-converter-mark.json" | ||
| CurrentVersion = 1 |
There was a problem hiding this comment.
How do we plan to use CurrentVersion?
It is a version that bumps when we changes format of the ConverterMark file or parquet file
| @@ -40,6 +42,10 @@ func NoCompactMarkFilenameMarkFilepath(blockID ulid.ULID) string { | |||
| return fmt.Sprintf("%s/%s-%s", MarkersPathname, blockID.String(), metadata.NoCompactMarkFilename) | |||
| } | |||
|
|
|||
| func ConverterMarkFilePath(blockID ulid.ULID) string { | |||
| return fmt.Sprintf("%s/%s-%s", MarkersPathname, blockID.String(), parquet.ConverterMarkerFileName) | |||
There was a problem hiding this comment.
Should we use a different marker path for parquet converter marker? Like parquet-markers/<blockID>-<marker-name>.
To avoid too many files inside the existing markers folder. It is also ok to use current path
| if err != nil { | ||
| if userBkt.IsObjNotFoundErr(err) { | ||
| return &ConverterMark{}, nil | ||
| } |
There was a problem hiding this comment.
Do we need to handle IsAccessDeniedErr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implementing parquet converter:
The documentation of this component is hidden for now as the feature is not code complete (We need to create the parquet queriable).
Which issue(s) this PR fixes:
Partially Fixes #6712
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]