-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atomic): migrate to Tailwind V4 #4923
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
...enerated-answer/atomic-generated-answer-feedback/atomic-generated-answer-feedback-modal.pcss
Show resolved
Hide resolved
...enerated-answer/atomic-generated-answer-feedback/atomic-generated-answer-feedback-modal.pcss
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/styles/feedback-buttons.pcss
Outdated
Show resolved
Hide resolved
I am curious what motivated this quite major lib update in the middle of a framework transition... I would feel more secure with screen video captures of some interfaces. |
@dmgauthier It is actually part of our move to Lit, as we want to already have everything in place as we convert the components to Lit, instead of a second phase of changes later just for the upgrade to tailwind 4 |
That's an excellent question, and the concern is well-placed. The timing of the migration is a key decision factor. If we were in the middle of migration (i.e., components had already been migrated or "touched" CSS), we would have postponed the migration. You are right that if we had migrated components, we would have doubled the risk, as we would have had to check the two stacks, which would have been burdensome, and we would probably not have taken this risk. However, right now essentially:
|
Ability to replace most of our component-specific stylesheets with just tailwind classes, with the new selectors. |
@fpbrault @louis-bompart |
This PR updates tailwind to V4
https://coveord.atlassian.net/browse/KIT-3925
Also includes:
https://coveord.atlassian.net/browse/KIT-3926
https://coveord.atlassian.net/browse/KIT-3928