Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atomic): migrate to Tailwind V4 #4923

Merged
merged 59 commits into from
Feb 25, 2025
Merged

chore(atomic): migrate to Tailwind V4 #4923

merged 59 commits into from
Feb 25, 2025

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Jan 31, 2025

Copy link

github-actions bot commented Feb 3, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.7 243.7 0
commerce 355 355 0
search 415 415 0
insight 406.2 406.2 0
recommendation 255.9 255.9 0
ssr 408.8 408.8 0
ssr-commerce 372.7 372.7 0

@fpbrault fpbrault marked this pull request as ready for review February 7, 2025 17:32
@fpbrault fpbrault requested review from a team as code owners February 7, 2025 17:32
@dmgauthier
Copy link
Contributor

dmgauthier commented Feb 10, 2025

I am curious what motivated this quite major lib update in the middle of a framework transition...

I would feel more secure with screen video captures of some interfaces.

@fpbrault
Copy link
Contributor Author

I am curious what motivated this quite major lib update in the middle of a framework transition...

I would feel more secure with screen video captures of some interfaces.

@dmgauthier It is actually part of our move to Lit, as we want to already have everything in place as we convert the components to Lit, instead of a second phase of changes later just for the upgrade to tailwind 4

@louis-bompart
Copy link
Collaborator

I am curious what motivated this quite major lib update in the middle of a framework transition...

I would feel more secure with screen video captures of some interfaces.

That's an excellent question, and the concern is well-placed.

The timing of the migration is a key decision factor. If we were in the middle of migration (i.e., components had already been migrated or "touched" CSS), we would have postponed the migration.
However, we are not: indeed, no components have been migrated yet, so doing the Tailwind 4 upgrade now is positive if we manage to do it with limited code changes.

You are right that if we had migrated components, we would have doubled the risk, as we would have had to check the two stacks, which would have been burdensome, and we would probably not have taken this risk. However, right now essentially:

  • We migrate Stencil TW stack (cool).
  • We ensure Lit is built straight on TW4, no migration to do afterward, and we rip some benefits right now (@fpbrault there were a couple, could you give some example to justify why the move is beneficial)

@fpbrault
Copy link
Contributor Author

I am curious what motivated this quite major lib update in the middle of a framework transition...
I would feel more secure with screen video captures of some interfaces.

That's an excellent question, and the concern is well-placed.

The timing of the migration is a key decision factor. If we were in the middle of migration (i.e., components had already been migrated or "touched" CSS), we would have postponed the migration. However, we are not: indeed, no components have been migrated yet, so doing the Tailwind 4 upgrade now is positive if we manage to do it with limited code changes.

You are right that if we had migrated components, we would have doubled the risk, as we would have had to check the two stacks, which would have been burdensome, and we would probably not have taken this risk. However, right now essentially:

  • We migrate Stencil TW stack (cool).
  • We ensure Lit is built straight on TW4, no migration to do afterward, and we rip some benefits right now (@fpbrault there were a couple, could you give some example to justify why the move is beneficial)

Ability to replace most of our component-specific stylesheets with just tailwind classes, with the new selectors.
Smaller bundle size.
Faster build.
No need for extra postcss plugins in our build process.
You can also check this page for what is new in V4: https://tailwindcss.com/blog/tailwindcss-v4

@dmgauthier
Copy link
Contributor

@fpbrault @louis-bompart
Thanks you for taking the time to address my concerns. That being said as of now, as long as we are making sure this is not breaking any layout. 🚢

@fpbrault fpbrault added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2025
@fpbrault fpbrault added this pull request to the merge queue Feb 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2025
@fpbrault fpbrault added this pull request to the merge queue Feb 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 25, 2025
@fpbrault fpbrault added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit 0965a64 Feb 25, 2025
125 checks passed
@fpbrault fpbrault deleted the KIT-3925 branch February 25, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants