Fix #58: Add missing ERC721 external burnable test and improve naming#61
Merged
nisedo merged 2 commits intocrytic:mainfrom Nov 26, 2025
Merged
Conversation
omarinuwa
approved these changes
Nov 26, 2025
omarinuwa
left a comment
omarinuwa
left a comment
There was a problem hiding this comment.
addresses issue 58, naming improvd and ERC721 external burnable test added
…naming - Add test_ERC721_external_burnRevertOnTransferFromZeroAddress test - Rename test_ERC721_external_burnRevertOnTransfer to test_ERC721_external_burnRevertOnTransferFromPreviousOwner for consistency - External properties now match internal properties with 6 tests each Resolves crytic#58
nisedo
force-pushed
the
fix/erc721-burnable-external-tests
branch
from
2c1152c to
6aa7580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #58