Skip to content

Fix #58: Add missing ERC721 external burnable test and improve naming #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nisedo merged 2 commits into from
Nov 26, 2025
Merged

Fix #58: Add missing ERC721 external burnable test and improve naming #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37579b6
Fix #58: Add missing ERC721 external burnable test and improve naming
nisedo Nov 24, 2025
6aa7580
Fix linter errors
nisedo Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions contracts/ERC721/external/properties/ERC721ExternalBurnableProperties.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ pragma solidity ^0.8.13;
import "../util/ERC721ExternalTestBase.sol";
import "../../../util/Hevm.sol";

abstract contract CryticERC721ExternalBurnableProperties is CryticERC721ExternalTestBase {
abstract contract CryticERC721ExternalBurnableProperties is
CryticERC721ExternalTestBase
{
using Address for address;

////////////////////////////////////////
// Properties

Expand All @@ -17,18 +20,27 @@ abstract contract CryticERC721ExternalBurnableProperties is CryticERC721External

uint256 oldTotalSupply = token.totalSupply();

for(uint256 i; i < selfBalance; i++) {
for (uint256 i; i < selfBalance; i++) {
uint256 tokenId = token.tokenOfOwnerByIndex(msg.sender, 0);
hevm.prank(msg.sender);
token.burn(tokenId);
}
// Check for underflow
assertWithMsg(selfBalance <= oldTotalSupply, "Underflow - user balance larger than total supply");
assertEq(oldTotalSupply - selfBalance, token.totalSupply(), "Incorrect supply update on burn");
assertWithMsg(
selfBalance <= oldTotalSupply,
"Underflow - user balance larger than total supply"
);
assertEq(
oldTotalSupply - selfBalance,
token.totalSupply(),
"Incorrect supply update on burn"
);
}

// A burned token should not be transferrable
function test_ERC721_external_burnRevertOnTransfer(address target) public virtual {
function test_ERC721_external_burnRevertOnTransferFromPreviousOwner(
address target
) public virtual {
require(token.isMintableOrBurnable());
uint256 selfBalance = token.balanceOf(msg.sender);
require(selfBalance > 0);
Expand All @@ -41,6 +53,20 @@ abstract contract CryticERC721ExternalBurnableProperties is CryticERC721External
assertWithMsg(false, "Transferring a burned token didn't revert");
}

function test_ERC721_external_burnRevertOnTransferFromZeroAddress(
address target
) public virtual {
require(token.isMintableOrBurnable());
uint256 selfBalance = token.balanceOf(msg.sender);
require(selfBalance > 0);

uint256 tokenId = token.tokenOfOwnerByIndex(msg.sender, 0);
hevm.prank(msg.sender);
token.burn(tokenId);
token.transferFrom(address(0), target, tokenId);
assertWithMsg(false, "Transferring a burned token didn't revert");
}

function test_ERC721_external_burnRevertOnApprove() public virtual {
require(token.isMintableOrBurnable());
uint256 selfBalance = token.balanceOf(msg.sender);
Expand Down
Loading