Add computation of std of drawer temperatures to the DQM #309
Conversation
- camera_monitoring.py: add computation of std of temperature for each drawer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 49.33% 49.09% -0.25%
==========================================
Files 85 85
Lines 7795 7840 +45
==========================================
+ Hits 3846 3849 +3
- Misses 3949 3991 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good to me. |
hashkar
left a comment
There was a problem hiding this comment.
All is ok to me for the changes in the DQM. Please ensure that all automatic checks have passed (the ones that are possible) and green light for merging.
Hi @hashkar , @alessandromontanari , Many thanks for this PR, @alessandromontanari , and your review, @hashkar ! |
|
@jlenain @alessandromontanari also 310 should have been in the same PR as this one and tested. I will test 310. |
Well, to me it is OK to have two separate PRs: I am rather an adept of "two different features introduced, two different pull requests". |
|
@jlenain problem is in line 23, 248 and 264 it is still plotting the mean. Sorry I missed it. |
I tend to prefer this logic too |
|
* feat(src/nectarchain/dqm): - camera_monitoring.py: add temperature trends with values for all drawers * `event_wrong_id` does not exist * Roll-back * feat(src/nectarchain/dqm): - camera_monitoring.py: add temperature trends with values for all drawers * Lint * fix what was missing from #309 for temperature std plots --------- Co-authored-by: Jean-Philippe Lenain <jlenain@in2p3.fr> Co-authored-by: Alessandro MONTANARI <montanari@llr.in2p3.fr>




feat(src/nectarchain/dqm):
This PR adds the computation of the std of drawer temperatures to the processor
camera_monitoring.py, following the same code logic as for the temperature mean.