Skip to content

Add computation of std of drawer temperatures to the DQM #309

Merged
jlenain merged 2 commits into
cta-observatory:mainfrom
alessandromontanari:dqm-drawers-temperature-rms
May 5, 2026
Merged

Add computation of std of drawer temperatures to the DQM #309
jlenain merged 2 commits into
cta-observatory:mainfrom
alessandromontanari:dqm-drawers-temperature-rms

Conversation

@alessandromontanari
Copy link
Copy Markdown
Contributor

feat(src/nectarchain/dqm):

  • camera_monitoring.py: add computation of std of temperature for each drawer

This PR adds the computation of the std of drawer temperatures to the processor camera_monitoring.py, following the same code logic as for the temperature mean.

- camera_monitoring.py: add computation of std of temperature for each drawer
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 3.92157% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.09%. Comparing base (bcb16b2) to head (8b6cc70).

Files with missing lines Patch % Lines
src/nectarchain/dqm/camera_monitoring.py 3.92% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   49.33%   49.09%   -0.25%     
==========================================
  Files          85       85              
  Lines        7795     7840      +45     
==========================================
+ Hits         3846     3849       +3     
- Misses       3949     3991      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessandromontanari alessandromontanari self-assigned this May 4, 2026
@hashkar
Copy link
Copy Markdown
Collaborator

hashkar commented May 5, 2026

Looks good to me.

Copy link
Copy Markdown
Collaborator

@hashkar hashkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is ok to me for the changes in the DQM. Please ensure that all automatic checks have passed (the ones that are possible) and green light for merging.

@jlenain
Copy link
Copy Markdown
Collaborator

jlenain commented May 5, 2026

All is ok to me for the changes in the DQM. Please ensure that all automatic checks have passed (the ones that are possible) and green light for merging.

Hi @hashkar , @alessandromontanari ,

Many thanks for this PR, @alessandromontanari , and your review, @hashkar !
I just first would like to process a DQM run locally, to check that everything runs fine, since the DQM code is not fully covered with unit tests.

@hashkar
Copy link
Copy Markdown
Collaborator

hashkar commented May 5, 2026

@jlenain @alessandromontanari also 310 should have been in the same PR as this one and tested. I will test 310.

@jlenain
Copy link
Copy Markdown
Collaborator

jlenain commented May 5, 2026

@jlenain @alessandromontanari also 310 should have been in the same PR as this one and tested. I will test 310.

Well, to me it is OK to have two separate PRs: I am rather an adept of "two different features introduced, two different pull requests".

@jlenain
Copy link
Copy Markdown
Collaborator

jlenain commented May 5, 2026

At the moment, a local DQM processing gives exactly the same plots for the mean and standard deviation:

image image

The same applies between mean and std when taking the temperature sensors "FEB1" or "FEB2" individually.

I think I see why, I'll fix it.

@hashkar
Copy link
Copy Markdown
Collaborator

hashkar commented May 5, 2026

@jlenain problem is in line 23, 248 and 264 it is still plotting the mean. Sorry I missed it.

@alessandromontanari
Copy link
Copy Markdown
Contributor Author

@jlenain @alessandromontanari also 310 should have been in the same PR as this one and tested. I will test 310.

Well, to me it is OK to have two separate PRs: I am rather an adept of "two different features introduced, two different pull requests".

I tend to prefer this logic too

@jlenain
Copy link
Copy Markdown
Collaborator

jlenain commented May 5, 2026

@jlenain problem is in line 23, 248 and 264 it is still plotting the mean. Sorry I missed it.

OK, much better now:
Screenshot from 2026-05-05 11-48-40
Screenshot from 2026-05-05 11-48-50

@jlenain jlenain added the enhancement New feature or request label May 5, 2026
@jlenain jlenain merged commit 4c46f5e into cta-observatory:main May 5, 2026
16 of 27 checks passed
@jlenain jlenain deleted the dqm-drawers-temperature-rms branch May 5, 2026 11:28
alessandromontanari added a commit to alessandromontanari/nectarchain that referenced this pull request May 6, 2026
jlenain added a commit that referenced this pull request May 18, 2026
* feat(src/nectarchain/dqm):

- camera_monitoring.py: add temperature trends with values for all drawers

* `event_wrong_id` does not exist

* Roll-back

* feat(src/nectarchain/dqm):

- camera_monitoring.py: add temperature trends with values for all drawers

* Lint

* fix what was missing from #309 for temperature std plots

---------

Co-authored-by: Jean-Philippe Lenain <jlenain@in2p3.fr>
Co-authored-by: Alessandro MONTANARI <montanari@llr.in2p3.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants