Skip to content

Add computation of std of drawer temperatures to the DQM #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlenain merged 2 commits into from
May 5, 2026
Merged

Add computation of std of drawer temperatures to the DQM #309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a51da
feat(src/nectarchain/dqm):
alessandromontanari Apr 30, 2026
8b6cc70
Bug fix: plotted mean temperatures instead of standard deviations
jlenain May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 77 additions & 6 deletions src/nectarchain/dqm/camera_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def __init__(self, gaink, r0=False):
self.DrawerNum2 = None
self.DrawerTemp1_mean = []
self.DrawerTemp2_mean = []
self.DrawerTemp1_std = []
self.DrawerTemp2_std = []
self.CameraMonitoring_Results_Dict = {}
self.ChargeInt_Figures_Dict = {}
self.ChargeInt_Figures_Names_Dict = {}
Expand Down Expand Up @@ -130,13 +132,25 @@ def finish_run(self):
self.DrawerTemp1_mean.append(
np.mean(self.DrawerTemp12[self.DrawerNum2 == i])
)
self.DrawerTemp1_std.append(
np.std(self.DrawerTemp12[self.DrawerNum2 == i])
)
self.DrawerTemp2_mean.append(
np.mean(self.DrawerTemp22[self.DrawerNum2 == i])
)
self.DrawerTemp2_std.append(
np.std(self.DrawerTemp22[self.DrawerNum2 == i])
)

self.DrawerTemp1_mean = np.array(self.DrawerTemp1_mean)
self.DrawerTemp2_mean = np.array(self.DrawerTemp2_mean)
self.DrawerTemp1_std = np.array(self.DrawerTemp1_std)
self.DrawerTemp2_std = np.array(self.DrawerTemp2_std)

self.DrawerTemp_mean = (self.DrawerTemp1_mean + self.DrawerTemp2_mean) / 2
# std of drawer temperatures as mean of std of temp FEB1 and temp FEB2
self.DrawerTemp_std = (self.DrawerTemp1_std + self.DrawerTemp2_std) / 2

except Exception as err:
log.error(
f"Drawer temperature could not be retrieved. Received error "
Expand All @@ -148,6 +162,9 @@ def get_results(self):
self.CameraMonitoring_Results_Dict[
"CAMERA-TEMPERATURE-AVERAGE"
] = self.DrawerTemp_mean
self.CameraMonitoring_Results_Dict[
"CAMERA-TEMPERATURE-STD"
] = self.DrawerTemp_std
except Exception as err:
log.error(
f"Drawer temperature could not be retrieved. Received error "
Expand All @@ -158,7 +175,7 @@ def get_results(self):

def plot_results(self, name, fig_path):
try:
fig, _ = plt.subplots()
fig_mean, _ = plt.subplots()
disp = CameraDisplay(self.camera)
disp.image = self.DrawerTemp_mean
disp.cmap = plt.cm.coolwarm
Expand All @@ -167,14 +184,14 @@ def plot_results(self, name, fig_path):
plt.title("Camera temperature average")
full_name = name + "_CameraTemperature_Mean.png"
full_path = os.path.join(fig_path, full_name)
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-AVERAGE"] = fig
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-AVERAGE"] = fig_mean
self.ChargeInt_Figures_Names_Dict[
"CAMERA-TEMPERATURE-IMAGE-AVERAGE"
] = full_path

plt.close()

fig1, disp = plt.subplots()
fig1_mean, _ = plt.subplots()
disp = CameraDisplay(self.camera)
disp.image = self.DrawerTemp1_mean
disp.cmap = plt.cm.coolwarm
Expand All @@ -183,14 +200,16 @@ def plot_results(self, name, fig_path):
plt.title("Camera temperature average 1")
full_name = name + "_CameraTemperature_average1.png"
full_path = os.path.join(fig_path, full_name)
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-AVERAGE-1"] = fig1
self.ChargeInt_Figures_Dict[
"CAMERA-TEMPERATURE-IMAGE-AVERAGE-1"
] = fig1_mean
self.ChargeInt_Figures_Names_Dict[
"CAMERA-TEMPERATURE-IMAGE-AVERAGE-1"
] = full_path

plt.close()

fig2, disp = plt.subplots()
fig2_mean, _ = plt.subplots()
disp = CameraDisplay(self.camera)
disp.image = self.DrawerTemp2_mean
disp.cmap = plt.cm.coolwarm
Expand All @@ -199,11 +218,63 @@ def plot_results(self, name, fig_path):
plt.title("Camera temperature average 2")
full_name = name + "_CameraTemperature_average2.png"
full_path = os.path.join(fig_path, full_name)
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-AVERAGE-2"] = fig2
self.ChargeInt_Figures_Dict[
"CAMERA-TEMPERATURE-IMAGE-AVERAGE-2"
] = fig2_mean
self.ChargeInt_Figures_Names_Dict[
"CAMERA-TEMPERATURE-IMAGE-AVERAGE-2"
] = full_path

plt.close()

fig_std, _ = plt.subplots()
disp = CameraDisplay(self.camera)
disp.image = self.DrawerTemp_std
disp.cmap = plt.cm.coolwarm
disp.axes.text(1.8, -0.3, "Temperature", fontsize=12, rotation=90)
disp.add_colorbar()
plt.title("Camera temperature std")
full_name = name + "_CameraTemperature_Std.png"
full_path = os.path.join(fig_path, full_name)
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-STD"] = fig_std
self.ChargeInt_Figures_Names_Dict[
"CAMERA-TEMPERATURE-IMAGE-STD"
] = full_path

plt.close()

fig1_std, _ = plt.subplots()
disp = CameraDisplay(self.camera)
disp.image = self.DrawerTemp1_std
disp.cmap = plt.cm.coolwarm
disp.axes.text(1.8, -0.3, "Temperature 1", fontsize=12, rotation=90)
disp.add_colorbar()
plt.title("Camera temperature std 1")
full_name = name + "_CameraTemperature_Std1.png"
full_path = os.path.join(fig_path, full_name)
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-STD-1"] = fig1_std
self.ChargeInt_Figures_Names_Dict[
"CAMERA-TEMPERATURE-IMAGE-STD-1"
] = full_path

plt.close()

fig2_std, _ = plt.subplots()
disp = CameraDisplay(self.camera)
disp.image = self.DrawerTemp2_std
disp.cmap = plt.cm.coolwarm
disp.axes.text(1.8, -0.3, "Temperature 2", fontsize=12, rotation=90)
disp.add_colorbar()
plt.title("Camera temperature std 2")
full_name = name + "_CameraTemperature_Std2.png"
full_path = os.path.join(fig_path, full_name)
self.ChargeInt_Figures_Dict["CAMERA-TEMPERATURE-IMAGE-STD-2"] = fig2_std
self.ChargeInt_Figures_Names_Dict[
"CAMERA-TEMPERATURE-IMAGE-STD-2"
] = full_path

plt.close()

except Exception as err:
log.error(f"Received error code: {err}")

Expand Down
Loading