feat(actions): add DomainNameResolver for human-friendly domain names #14355
+202
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds DomainNameResolver class to resolve domain URNs to human-readable display names in datahub-actions messages, improving user experience by showing friendly domain names instead of technical identifiers. Resolves: acryldata/datahub-actions#65 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
the
community-contribution
datahub-cyborg
bot
added
the
needs-review
|
Thanks for raising the PR! @hsheth2 could you take a look at this? |
datahub-cyborg
bot
added
pending-submitter-response
hsheth2
reviewed
Aug 7, 2025
Adds 10 unit test cases covering DomainNameResolver functionality: - Tests with/without DataHubGraph scenarios - Validates fallback behavior for missing/empty domain properties - Verifies NameResolverRegistry integration - Tests edge cases including None and empty string names - Ensures proper mocking and API contract verification All tests pass and follow existing code patterns and conventions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixes type error where DomainPropertiesClass constructor was passed None for name parameter. Uses Mock object with name attribute set to None instead to satisfy type checking. All tests continue to pass and mypy reports success with no issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
datahub-cyborg
bot
added
needs-review
hsheth2
reviewed
Aug 8, 2025
There was a problem hiding this comment.
these tests look extremely verbose - I was expecting something more like ~50 lines of code for the tests
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DomainNameResolver class to resolve domain URNs to human-readable display names in datahub-actions messages, improving user experience by showing friendly domain names instead of technical identifiers.
Resolves: acryldata/datahub-actions#65