feat(i18n): translate identity & permissions to German (CAT-2320)#17749
Open
annadoesdesign wants to merge 1 commit into
Open
feat(i18n): translate identity & permissions to German (CAT-2320)#17749annadoesdesign wants to merge 1 commit into
annadoesdesign wants to merge 1 commit into
Conversation
The identity & permissions extraction (CAT-2234 / PR #17689) added keys to two existing namespaces — entity.identity and settings.permissions — rather than a new governance.identity namespace as the ticket title implies. This PR fills in the matching DE keys (formal Sie form). - entity.identity.json: +19 keys (group delete/copy URN actions, serviceAccount default-view + delete + roleAssign messages, groups.membersCount plural forms) - settings.permissions.json: +6 keys (policy activate/deactivate/delete/remove/save success messages and the delete confirmation dialog) Translation choices follow conventions already used in these files: - Policy → Richtlinie, Group → Gruppe, Owner kept as-is, Service Account kept as-is, URN kept as-is - German quotation marks „…" for inline quoted UI strings - i18next _one/_other plural forms preserved with German singular/plural Verified with scripts/check-translations.mjs --lang de: both namespaces now report complete. All {{name}}, {{error}}, {{role}}, and {{formattedCount}} interpolations preserved. Closes CAT-2320 Co-authored-by: Cursor <cursoragent@cursor.com>
|
✅ Meticulous spotted 0 visual differences across 1423 screens tested: view results. Meticulous evaluated ~10 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
Bundle ReportChanges will increase total bundle size by 1.83kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
maggiehays
added
the
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the German (DE) translations for the keys added by the identity & permissions extraction (CAT-2234 → PR #17689).
Scope note: the Linear ticket description references a
governance.identitynamespace, but the actual extraction PR added keys to two existing namespaces —entity.identityandsettings.permissions— rather than creating a new file. This PR translates the keys that actually landed.entity.identity.json: +19 keys (group delete / copy URN actions, serviceAccount default-view + delete + roleAssign messages,groups.membersCountplural forms)settings.permissions.json: +6 keys (policy activate / deactivate / delete / remove / save success messages and the delete confirmation dialog)Translation choices follow conventions already used in these files:
Policy → Richtlinie,Group → GruppeOwner/Service Account/URNkept as-is„…"for inline quoted UI strings_one/_otherplural forms with German singular / pluralCloses CAT-2320.
Test plan
node scripts/check-translations.mjs --lang de— both namespaces now report complete{{name}},{{error}},{{role}},{{formattedCount}}interpolations preserved verbatimprettier --writeon both files is a no-op (already correctly formatted)Made with Cursor