New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve deleted field reservation for list events #33

Merged

henry739 merged 1 commit into main from dev/henry/9754-incomplete-field-reservation

Aug 9, 2024

Contributor

henry739 commented Jul 31, 2024 •

edited by azure-boards bot

Loading

I did some digging to find the "missing" name of deleted field 8 in ListEventsRequest:

// user defined attributes key max_length: 1024 value max_length: 4096
map<string, string> attributes = 8;

It seems that fields 9 and 10 were simply omitted when this message was first defined.


          improve deleted field reservation for list events

51073f8

re AB#9754

henry739 requested review from eccles, robinbryce and wp0pw

July 31, 2024 10:24

azure-boards bot commented Jul 31, 2024

✅ Successfully linked to Azure Boards work item(s):

Bug 9754

eccles approved these changes

View reviewed changes

henry739 merged commit e48e5d8 into main

3 checks passed

henry739 deleted the dev/henry/9754-incomplete-field-reservation branch

August 9, 2024 16:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet