Fix bug with missed columns in the column pruner #1679
Merged
+188
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
changed the title
This was referenced Feb 21, 2025
courtneyholcomb
approved these changes
Feb 21, 2025
plypaul
added a commit
that referenced
this pull request
Feb 21, 2025
This PR renames a few variables and methods in the column pruner classes in preparation for #1679.
plypaul
added a commit
that referenced
this pull request
Feb 21, 2025
This PR consolidates a couple of loops in `SqlMapRequiredColumnAliasesVisitor` and replaces `.add_alias()` calls with `.add_aliases()` to reduce nesting. There are no logic changes in this PR, and this is mainly to make #1679 a simple change given the complexity in that class. There is some additional consolidation that can be done with other loops, but leaving those out of scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the column pruner does not correctly keep track of columns that are used in
SqlStringExpressionandSqlColumnAliasReferenceExpression. Those expressions are different from other expressions as they do not have a table alias, and there is existing case handling for those expressions. The bug is that the handler did not propagate the knowledge that columns from those expressions is required to the available CTEs.This bug currently does not affect queries due to the way that we wrap access to CTEs in a
SELECT, but fixing this as it affects later work.