Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset Loading Race Condition Fix
Context and Problem Statement
When dragging and dropping assets (particularly NFTs and smart items) into the canvas, there was a race condition where the asset would fail to load on the first attempt but succeed on subsequent attempts. This occurred because the asset was requested before it was fully downloaded and available in the filesystem.
Solution
Implemented a retry mechanism in the
SceneContext.getFile()
method to handle cases where an asset is temporarily unavailable. This provides a more robust solution without introducing unnecessary complexity.Key changes:
getFile()
with a maximum of 3 attemptsTesting
Impact
This change improves the reliability of asset loading in the Inspector, particularly for NFTs and smart items. Users will no longer experience failed first attempts when dragging and dropping these assets into the canvas.
Closes: decentraland/creator-hub#346