chore: added realminfo documentation #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this pull request
|
| int32 network_id = 3; // the Ethereum network | ||
| string comms_adapter = 4; // comms adapter, removing all query parameters (credentials) | ||
| bool is_preview = 5; // true if the scene is running as a local preview, instead of published in Decentraland. | ||
| optional string room = 6; // the room session id. |
There was a problem hiding this comment.
I'm thinking of changing this to
optional string room = 6; // (internal use) the room session id.
There was a problem hiding this comment.
I think can be useful for Scene Developer to know if the clients are in the same room and they see each other
kuruk-mm
reviewed
Feb 5, 2025
| string base_url = 1; // the domain of the realm server | ||
| string realm_name = 2; // the name of the realm server | ||
| int32 network_id = 3; // the Ethereum network | ||
| string comms_adapter = 4; // comms adapter, removing all query parameters (credentials) |
There was a problem hiding this comment.
Suggested change
| string comms_adapter = 4; // comms adapter, removing all query parameters (credentials) | |
| string comms_adapter = 4; // comms adapter (more info https://adr.decentraland.org/adr/ADR-180) |
kuruk-mm
reviewed
Feb 5, 2025
| optional string room = 6; | ||
| optional bool is_connected_scene_room = 7; | ||
| string base_url = 1; // the domain of the realm server | ||
| string realm_name = 2; // the name of the realm server |
There was a problem hiding this comment.
Suggested change
| string realm_name = 2; // the name of the realm server | |
| string realm_name = 2; // the name of the realm server (more info https://adr.decentraland.org/adr/ADR-110) |
kuruk-mm
reviewed
Feb 5, 2025
| optional bool is_connected_scene_room = 7; | ||
| string base_url = 1; // the domain of the realm server | ||
| string realm_name = 2; // the name of the realm server | ||
| int32 network_id = 3; // the Ethereum network |
There was a problem hiding this comment.
Suggested change
| int32 network_id = 3; // the Ethereum network | |
| int32 network_id = 3; // the network id (1=Ethereum, more info https://chainlist.org/) |
kuruk-mm
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation to realm info protobuf definition