Skip to content

FreshworksFreshservice: hide mirroring params on unsupported platforms#44309

Merged
DeanArbel merged 2 commits into
masterfrom
da_XSUP-69099_Freshwork_mirror
May 14, 2026
Merged

FreshworksFreshservice: hide mirroring params on unsupported platforms#44309
DeanArbel merged 2 commits into
masterfrom
da_XSUP-69099_Freshwork_mirror

Conversation

@DeanArbel
Copy link
Copy Markdown
Contributor

Status

  • Ready

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-69099

Description

Hides mirror related parameters for unsupported platforms.

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@DeanArbel DeanArbel force-pushed the da_XSUP-69099_Freshwork_mirror branch from d551503 to a8f8086 Compare May 14, 2026 13:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

@DeanArbel DeanArbel added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. docs-approved labels May 14, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 14, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@DeanArbel DeanArbel enabled auto-merge (squash) May 14, 2026 14:11
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for contributing to the Freshworks Freshservice pack. I've reviewed the changes and have a few quick notes regarding formatting and documentation. Please update the README to clarify that the hidden mirroring parameters are XSOAR-only, fix the root key order in the integration YML, and correct the markdown formatting in the release notes. Thanks again for your work!

Additionally, please address the following file-level notes:

  • Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml: The first key defined at the root level of the .yml file must always be name or display. Currently, it starts with category. Please reorder the root keys to comply with the XSOAR Integration YML Guidelines.

@kamalq97, @DeanArbel please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

type: 15
required: false
section: Collect
hidden:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these mirroring parameters are now hidden on marketplacev2 and platform, please ensure the README.md is updated to reflect that these features are only available on XSOAR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the updates to the README.md file in the latest diff. Could you please verify that the changes were committed and pushed?

Comment thread Packs/FreshworksFreshservice/ReleaseNotes/1_1_7.md Outdated

## Freshworks Freshservice

- Maintenance and stability enhancements.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid release note prefix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release note entry - Metadata and documentation improvements. still does not use an approved prefix or template. Please use the exact approved full-line template: Documentation and metadata improvements. (or - Documentation and metadata improvements.).

@DeanArbel DeanArbel force-pushed the da_XSUP-69099_Freshwork_mirror branch from a8f8086 to e343c32 Compare May 14, 2026 14:47
@DeanArbel DeanArbel added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 14, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 14, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔄 Re-reviewing updates...

Important

To maintain review integrity, threads marked as Resolved without accompanying changes or explanations will be automatically unresolved for further verification.

Thanks for your updates to the FreshworksFreshservice integration! I've reviewed the PR and have a few quick adjustments for you to make.

Please hide the fetch_ticket_task parameter for XSIAM/Cortex to keep the mirroring settings consistent, and restore the README note explaining these hidden parameters so users aren't confused. Finally, ensure the YAML file starts with the name or display key and that the release notes follow the approved format.

Let me know if you have any questions!

Additionally, please address the following file-level notes:

  • Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml: - The fetch_ticket_task parameter is also related to mirroring but was not hidden for marketplacev2 and platform. Please consider hiding it as well for consistency.
  • The first key defined at the root level of the .yml file must always be name or display. Currently, the file starts with category. Please reorder the keys so that name or display is at the very top.

@kamalq97, @DeanArbel, @marketplace-ai-reviewer please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

## Incident Mirroring
## Incident Mirroring (Cortex XSOAR only)

You can enable incident mirroring between Cortex XSOAR incidents and Freshworks Freshservice corresponding events (available from Cortex XSOAR version 6.0.0).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description indicates the intent to hide mirror-related parameters for unsupported platforms. This note provides valuable context to users about which specific parameters are hidden on Cortex XSIAM and the Cortex platform. Removing it might cause confusion for users who are looking for these parameters but cannot find them. Please consider restoring this note to maintain clarity.

Suggested change
You can enable incident mirroring between Cortex XSOAR incidents and Freshworks Freshservice corresponding events (available from Cortex XSOAR version 6.0.0).
**Note:** Incident mirroring is supported on Cortex XSOAR only. The mirroring configuration parameters (**Incident Mirroring Direction**, **Close Mirrored XSOAR Incident**, **Close Mirrored Freshservice Ticket**, and **Fetch tickets tasks**) are hidden on Cortex XSIAM and the Cortex platform.

For more information on documentation standards, see Creating Documentation.


##### Freshworks Freshservice

- Metadata and documentation improvements.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid release note entry format. Please use the exact approved template or an approved prefix.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: GR110, PB130, PB131, MC101, RM108.
The following errors were thrown as a part of this pr: AS103.
The following errors can be ignored: AS103.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ❌

@DeanArbel DeanArbel disabled auto-merge May 14, 2026 16:29
@DeanArbel DeanArbel merged commit 01c163c into master May 14, 2026
33 of 39 checks passed
@DeanArbel DeanArbel deleted the da_XSUP-69099_Freshwork_mirror branch May 14, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants