FreshworksFreshservice: hide mirroring params on unsupported platforms#44309
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
d551503 to
a8f8086
Compare
Coverage Report
|
||||||||||||||||||||||||||||||
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for contributing to the Freshworks Freshservice pack. I've reviewed the changes and have a few quick notes regarding formatting and documentation. Please update the README to clarify that the hidden mirroring parameters are XSOAR-only, fix the root key order in the integration YML, and correct the markdown formatting in the release notes. Thanks again for your work!
Additionally, please address the following file-level notes:
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml: The first key defined at the root level of the.ymlfile must always benameordisplay. Currently, it starts withcategory. Please reorder the root keys to comply with the XSOAR Integration YML Guidelines.
@kamalq97, @DeanArbel please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| type: 15 | ||
| required: false | ||
| section: Collect | ||
| hidden: |
There was a problem hiding this comment.
Since these mirroring parameters are now hidden on marketplacev2 and platform, please ensure the README.md is updated to reflect that these features are only available on XSOAR.
There was a problem hiding this comment.
I don't see the updates to the README.md file in the latest diff. Could you please verify that the changes were committed and pushed?
|
|
||
| ## Freshworks Freshservice | ||
|
|
||
| - Maintenance and stability enhancements. |
There was a problem hiding this comment.
Invalid release note prefix.
There was a problem hiding this comment.
The release note entry - Metadata and documentation improvements. still does not use an approved prefix or template. Please use the exact approved full-line template: Documentation and metadata improvements. (or - Documentation and metadata improvements.).
a8f8086 to
e343c32
Compare
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
🔄 Re-reviewing updates...
Important
To maintain review integrity, threads marked as Resolved without accompanying changes or explanations will be automatically unresolved for further verification.
Thanks for your updates to the FreshworksFreshservice integration! I've reviewed the PR and have a few quick adjustments for you to make.
Please hide the fetch_ticket_task parameter for XSIAM/Cortex to keep the mirroring settings consistent, and restore the README note explaining these hidden parameters so users aren't confused. Finally, ensure the YAML file starts with the name or display key and that the release notes follow the approved format.
Let me know if you have any questions!
Additionally, please address the following file-level notes:
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml: - Thefetch_ticket_taskparameter is also related to mirroring but was not hidden formarketplacev2andplatform. Please consider hiding it as well for consistency.- The first key defined at the root level of the
.ymlfile must always benameordisplay. Currently, the file starts withcategory. Please reorder the keys so thatnameordisplayis at the very top.
@kamalq97, @DeanArbel, @marketplace-ai-reviewer please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| ## Incident Mirroring | ||
| ## Incident Mirroring (Cortex XSOAR only) | ||
|
|
||
| You can enable incident mirroring between Cortex XSOAR incidents and Freshworks Freshservice corresponding events (available from Cortex XSOAR version 6.0.0). |
There was a problem hiding this comment.
The PR description indicates the intent to hide mirror-related parameters for unsupported platforms. This note provides valuable context to users about which specific parameters are hidden on Cortex XSIAM and the Cortex platform. Removing it might cause confusion for users who are looking for these parameters but cannot find them. Please consider restoring this note to maintain clarity.
| You can enable incident mirroring between Cortex XSOAR incidents and Freshworks Freshservice corresponding events (available from Cortex XSOAR version 6.0.0). | |
| **Note:** Incident mirroring is supported on Cortex XSOAR only. The mirroring configuration parameters (**Incident Mirroring Direction**, **Close Mirrored XSOAR Incident**, **Close Mirrored Freshservice Ticket**, and **Fetch tickets tasks**) are hidden on Cortex XSIAM and the Cortex platform. |
For more information on documentation standards, see Creating Documentation.
|
|
||
| ##### Freshworks Freshservice | ||
|
|
||
| - Metadata and documentation improvements. |
There was a problem hiding this comment.
Invalid release note entry format. Please use the exact approved template or an approved prefix.
|
Validate summary Verdict: PR can be force merged from validate perspective? ❌ |
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-69099
Description
Hides mirror related parameters for unsupported platforms.