feat: add keys() and vals() for AssocList
#646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @dpanchenko, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
timohanke
reviewed
Jul 22, 2024
timohanke
left a comment
timohanke
left a comment
There was a problem hiding this comment.
I think we can use List.toIter instead of the entries function defined here. It is the same code, but just because List.toIter already exists we don't need to provide it a second time.
|
Resolves #581 |
|
I don't know about the size requirement for keys() and vals(). Does anyone know if it is really O(1)? |
ggreif
changed the title
keys() and vals() for AssocList
ggreif
changed the title
keys() and vals() for AssocListkeys() and vals() for AssocList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.