-
Notifications
You must be signed in to change notification settings - Fork 218
Build macOS binaries with Travis #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis has experimental windows support, so you can build in the three envs, what do you think? |
@jneira the only purpose of this Travis build is to output macOS binaries, so I wouldn't want to enable anything else on the matrix (since we already build Windows on Appveyor and Linux on Hydra) |
Yeah, i was thinking in remove appveyor (but keep nix) to somewhat unify the ci, appveyor has one hour of build time limit |
@jneira I see. I really don't like Travis, I'd say if we have to setup out new CI builds we could try Azure. Recently both EDIT: oh I just realized you said basically the same thing in #1063 😄 |
Yep, my idea is to use only one, travis already has cache support and azure has stable windows env and more concurrent jobs (i think). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone that's done work in this file, lemme say that this looks great! I look forward to seeing this working again!
I left a few superficial comments. Feel free to ignore them or follow them, whatever you feel like.
Co-Authored-By: Hardy Jones <[email protected]>
Co-Authored-By: Hardy Jones <[email protected]>
Co-Authored-By: Hardy Jones <[email protected]>
@f-f: Alright, Travis is enabled with a |
@f-f: Hmmm. For some reason Travis doesn't seem to be registering the existence of your pull request. You might have to close and reopen your pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this is enabled, will be running this on pull requests or just the master
branch and tags?
It will build PRs, master and tags. There is the following rule in the config, that might be confusing in this regard: # Build only master and release tags
branches:
only:
- master
- /^\d+\.\d+\.\d+(\.\d+)?$/ This is to prevent other branches from being built, because they are covered by Travis' "PR builds", otherwise you'd get two builds from every PR with a branch in this repo (and if you disable "branch builds" in Travis then you don't get builds for releases at all) |
This is great! Can we expect a release soon that includes these binaries? |
@paulyoung yep, once Dhall 9 is out (sometime in the coming days) there will be a matching release for the Haskell package too |
@f-f: Thank you for doing this! 🙂 |
You're welcome 🙂 |
@f-f it occurred to me that the binaries built by Travis might be available somewhere in the meantime. Is that the case? |
@paulyoung the binaries are indeed build at every CI run, but they are not uploaded anywhere, so they get "lost" after the build is done (and there's no way to recover them as far as I know) |
Now that Dhall 9 has been released, is there a timeframe for a new dhall-haskell release? |
@paulyoung: ~3 days. I'm going to begin the process of cutting the release tonight |
@paulyoung: The executables are available now from the releases page: https://github.com/dhall-lang/dhall-haskell/releases |
Fix #737
This PR changes the Travis build (I'm replacing the current one which I don't understand with the one from spago which I mostly wrote) to compile macOS binaries and push them to GitHub releases alongside the Linux and Windows binaries.
Things left to do:
$API_KEY
variable to authenticate to GitHub (though I can reuse the current$GITHUB_OAUTH_TOKEN
if it's still there)tar
operations to thebefore_deploy
section