Skip to content

Update Dockerfile#7723

Closed
HAjAdnan wants to merge 1 commit into
diegosouzapw:release/v3.8.49from
HAjAdnan:patch-2
Closed

Update Dockerfile#7723
HAjAdnan wants to merge 1 commit into
diegosouzapw:release/v3.8.49from
HAjAdnan:patch-2

Conversation

@HAjAdnan

Copy link
Copy Markdown

Summary

  • Describe the user-facing or operational change.

Related Issues

  • Closes #
  • Related to #

Validation

  • npm run lint
  • npm run test:unit
  • npm run test:coverage
  • Coverage is still >= 60% for statements, lines, functions, and branches
  • SonarQube PR analysis is green or any remaining issues are explicitly documented below

Tests Added Or Updated

  • List every changed or added automated test file.
  • If no production code changed, state that here.

Coverage Notes

  • If this PR changes src/, open-sse/, electron/, or bin/, explain which tests cover the change.
  • If coverage moved down in any touched file, explain why and what follow-up task will recover it.

Reviewer Notes

  • Call out any risky areas, migrations, feature flags, or manual validation that reviewers should know about.

@HAjAdnan
HAjAdnan requested a review from diegosouzapw as a code owner July 19, 2026 05:31
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@diegosouzapw

Copy link
Copy Markdown
Owner

Thank you for taking the time to clean up the Dockerfile — attention to the build setup is genuinely appreciated, and we love seeing contributors dig into the infra side. 🙏

I looked closely and unfortunately I have to close this one, so let me explain exactly why so it's useful for you: this change removes the explicit id= argument from the BuildKit cache mounts (5 of them — apt-cache, apt-lists, next-cache, npm-cache, playwright apt). Those id= attributes aren't cosmetic — they were added deliberately in #6291 to fix a real parse failure on strict BuildKit frontends (notably Railway's Metal builder), which reject RUN --mount=type=cache mounts that don't carry an explicit id=. Standard docker buildx tolerates id-less mounts fine, so local builds look green, but the strict-frontend deploy path would break silently.

So this would reintroduce a bug we already fixed, which is why I'm closing rather than merging. None of your diff is being taken — this is purely "the current state is intentional", not us using your work without credit.

If you were hitting an actual problem with the current mounts (a warning, a cache miss, a specific builder complaining), I'd genuinely love to hear the details — open an issue or a new PR describing the symptom and we'll fix the root cause together. Please keep the contributions coming — infra PRs are exactly the kind of help the project needs. 🚀

@diegosouzapw diegosouzapw mentioned this pull request Jul 19, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants