ansi_c_parsert: construct with message handler #8141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
d1d421c to
cf789e9
Compare
4 tasks
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
cf789e9 to
f0501e4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8141 +/- ##
===========================================
- Coverage 79.65% 79.64% -0.01%
===========================================
Files 1684 1684
Lines 195565 195606 +41
===========================================
+ Hits 155774 155794 +20
- Misses 39791 39812 +21 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
f0501e4 to
98ab25b
Compare
3 tasks
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
98ab25b to
1bc179f
Compare
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
1bc179f to
57ca4bf
Compare
tautschnig
requested review from
kroening,
peterschrammel,
feliperodri and
remi-delmas-3000
as code owners
feliperodri
approved these changes
Feb 1, 2024
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
fbf9498 to
e5f6835
Compare
peterschrammel
approved these changes
Mar 12, 2024
|
|
||
| virtual void clear() override | ||
| void clear() override |
There was a problem hiding this comment.
❓ Is this function still used anywhere?
There was a problem hiding this comment.
I will clean this up across the type hierarchy (removing just this override seems dangerous, as any use of .clear() would just invoke parsert::clear(), which would end up in incomplete cleanup) in a follow-up PR.
4 tasks
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
e5f6835 to
abb26db
Compare
The test will sometimes pass, depending on what model the solver produces. When such a passing model happens to be is produced, it breaks our checking of "KNOWNBUG" tests.
This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor. The C scanner is now fully reentrant.
tautschnig
force-pushed
the
cleanup/ansi_c_parsert
branch
from
abb26db to
1f240bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor.