use sva_sequence_repetition_exprt for [*] and [+]
#1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
sva_sequence_repetition
branch
from
41c817d to
4a8f099
Compare
|
Needs a rebase. |
The base class sva_sequence_repetition_exprt is now also used for the SVA consecutive sequence repetition operators [*] and [+].
kroening
force-pushed
the
sva_sequence_repetition
branch
from
4a8f099 to
1f6926e
Compare
done |
tautschnig
approved these changes
Apr 30, 2025
| PRECONDITION(false); // no support | ||
| // Is op a sequence or a state predicate? | ||
| if(is_SVA_sequence_operator(op)) | ||
| PRECONDITION(false); // no support |
There was a problem hiding this comment.
Is this the right way to report this problem, or should this be an exception (with a human-readable error message) instead? (I acknowledge that this is the same behaviour as before.)
There was a problem hiding this comment.
Will implement, separate PR coming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base class
sva_sequence_repetition_exprtis now also used for the SVA consecutive sequence repetition operators[*]and[+].