Verilog: enum constants may depend on elaboration-time constants #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
dependent-enum-constants
branch
from
9c4c997 to
2a10285
Compare
tautschnig
approved these changes
Feb 21, 2024
| @@ -1344,7 +1349,16 @@ exprt verilog_typecheck_exprt::elaborate_constant_expression(exprt expr) | |||
|
|
|||
| // We fall back to the simplifier to approximate | |||
| // the standard's definition of 'constant expression'. | |||
| return simplify_expr(expr, ns); | |||
| auto simplified_expr = simplify_expr(expr, ns); | |||
There was a problem hiding this comment.
Because we've been bitten by this in CBMC (cf. diffblue/cbmc#7856): any use of the simplifier in the front-end needs to make sure that the resulting expression still has a source location.
This postpones the conversion of enum base types and enum initializers to enable them to depend on other elaboration-time constants.
kroening
force-pushed
the
dependent-enum-constants
branch
from
2a10285 to
1dd80c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This postpones the conversion of enum base types and enum initializers to enable them to depend on other elaboration-time constants.