-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove files used for running tests #12
Conversation
src/diffpy/nmf_mapping/tests/run.py
Outdated
@@ -13,7 +13,7 @@ | |||
# | |||
############################################################################## | |||
"""Convenience module for executing all unit tests with | |||
python -m \.tests.run | |||
python -m diffpy.nmf_mapping.tests.run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong syntax here as we are moving over to using pytest to run tests. Please look in cookicutter or one of the other projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the cookiecutter repo, I see it is the latest tests/run.py
file:
I checked diffpy.structure
https://github.com/diffpy/diffpy.structure/blob/main/src/diffpy/structure/tests/run.py
but it seems even older.
What is the "latest" one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just delete this run.py? Then in the ci (and when we run it locally) we just run pytest
or coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls e comments
src/diffpy/nmf_mapping/tests/run.py
Outdated
@@ -13,7 +13,7 @@ | |||
# | |||
############################################################################## | |||
"""Convenience module for executing all unit tests with | |||
python -m \.tests.run | |||
python -m diffpy.nmf_mapping.tests.run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong syntax here as we are moving over to using pytest to run tests. Please look in cookicutter or one of the other projects
@sbillinge Please see diffpy/diffpy.snmf#72 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls see inline
src/diffpy/nmf_mapping/tests/run.py
Outdated
@@ -13,7 +13,7 @@ | |||
# | |||
############################################################################## | |||
"""Convenience module for executing all unit tests with | |||
python -m \.tests.run | |||
python -m diffpy.nmf_mapping.tests.run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just delete this run.py? Then in the ci (and when we run it locally) we just run pytest
or coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files used for running tests removed.
This will be the last edit in a while.
Now, other diffpy projects will be priotized.
@bobleesj this is failing tests. Do you want me to merge it and get tests passing on a separate PR? |
Same as the title:
Addressing #10 (review)