Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files used for running tests #12

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

bobleesj
Copy link
Contributor

Same as the title:

Addressing #10 (review)

@bobleesj bobleesj marked this pull request as ready for review August 12, 2024 12:47
@@ -13,7 +13,7 @@
#
##############################################################################
"""Convenience module for executing all unit tests with
python -m \.tests.run
python -m diffpy.nmf_mapping.tests.run
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 passes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong syntax here as we are moving over to using pytest to run tests. Please look in cookicutter or one of the other projects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just delete this run.py? Then in the ci (and when we run it locally) we just run pytest or coverage

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls e comments

@@ -13,7 +13,7 @@
#
##############################################################################
"""Convenience module for executing all unit tests with
python -m \.tests.run
python -m diffpy.nmf_mapping.tests.run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong syntax here as we are moving over to using pytest to run tests. Please look in cookicutter or one of the other projects

@bobleesj
Copy link
Contributor Author

@sbillinge Please see diffpy/diffpy.snmf#72

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see inline

@@ -13,7 +13,7 @@
#
##############################################################################
"""Convenience module for executing all unit tests with
python -m \.tests.run
python -m diffpy.nmf_mapping.tests.run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just delete this run.py? Then in the ci (and when we run it locally) we just run pytest or coverage

Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files used for running tests removed.

This will be the last edit in a while.

Now, other diffpy projects will be priotized.

@bobleesj bobleesj changed the title Fix typo in run.py to run flake8 Remove files used for running tests Aug 13, 2024
@sbillinge
Copy link
Contributor

@bobleesj this is failing tests. Do you want me to merge it and get tests passing on a separate PR?

@bobleesj
Copy link
Contributor Author

@bobleesj this is failing tests. Do you want me to merge it and get tests passing on a separate PR?

Yes, please merge this one.

For diffpy.nmf_mapping, 3 out of 4 tests have not been passing for some reason from the start. Probably we shall look into this later. Made an issue for now.

#14

@sbillinge sbillinge merged commit f9c0e9a into diffpy:cookie Aug 13, 2024
2 of 3 checks passed
@bobleesj bobleesj deleted the cookierelease-typo branch August 13, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants