Skip to content

Remove files used for running tests #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2024
+0 −50
Merged

Remove files used for running tests #12

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8816a6
Fix typo in run.py to run flake8
bobleesj Aug 12, 2024
451fd78
Fix from snmf to nmf_mapping
bobleesj Aug 12, 2024
a9913c8
Fix snmf to nmf_mapping in comment
bobleesj Aug 12, 2024
dd2d5c2
Remove files for testing
bobleesj Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/diffpy/nmf_mapping/tests/run.py
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@
#
##############################################################################
"""Convenience module for executing all unit tests with
python -m \.tests.run
python -m diffpy.nmf_mapping.tests.run
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 passes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong syntax here as we are moving over to using pytest to run tests. Please look in cookicutter or one of the other projects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the cookiecutter repo, I see it is the latest tests/run.py file:

https://github.com/Billingegroup/cookiecutter/blob/main/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/%7B%7B%20cookiecutter.package_dir_name%20%7D%7D/tests/run.py

I checked diffpy.structure

https://github.com/diffpy/diffpy.structure/blob/main/src/diffpy/structure/tests/run.py

but it seems even older.

What is the "latest" one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just delete this run.py? Then in the ci (and when we run it locally) we just run pytest or coverage

"""

import sys