Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Add async methods in System.Data.Common, implement IAsyncDisposable #37877

Merged
merged 1 commit into from
May 30, 2019
Merged

Add async methods in System.Data.Common, implement IAsyncDisposable #37877

merged 1 commit into from
May 30, 2019
+171 −0

Conversation

roji
Copy link
Member

@roji roji commented May 22, 2019

Closes #35012

@roji roji requested review from divega and ajcvickers May 22, 2019 20:33
ajcvickers
ajcvickers approved these changes May 22, 2019
View reviewed changes
Copy link

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @divega to double check the API surface.

@roji
Copy link
Member Author

roji commented May 23, 2019

ping @divega for an extra set of eyes

divega
divega approved these changes May 30, 2019
View reviewed changes
Copy link

@divega divega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can recall, when we did #36123 we learned that we don’t need to do the dance with partials and *.netcoreapp.cs files in product code, I think because we are no longer building the package that targets other TFMs from the source in master.

If this is true, my preference would be to consolidate the code files.

Other than that, everything looks good to me.

@roji roji force-pushed the AsynchronizeSystemData branch from c481050 to 6259b22 Compare May 30, 2019 10:42
@roji
Copy link
Member Author

roji commented May 30, 2019

@divega you're right, I did a test build in #38051 and it works - seems like the issue was with the tests in #36123, and we currently don't have any in this PR. Rebased, squashed and removed the netcoreapp special-casing.

@roji roji merged commit 22dd87e into dotnet:master May 30, 2019
@roji roji deleted the AsynchronizeSystemData branch May 30, 2019 13:23
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
@roji roji mentioned this pull request Aug 30, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@bgrainger bgrainger bgrainger approved these changes

@divega divega divega approved these changes

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Add missing async methods in System.Data.Common and implement IAsyncDisposable
6 participants
@roji @bgrainger @divega @ajcvickers @stephentoub @karelz