-
Notifications
You must be signed in to change notification settings - Fork 27
[Autofill password import] animate export password only once #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 12 Feb 2025 16:04:00 GMT Android
File has changed Integration
File has changed |
766ac48
to
591dcc0
Compare
84ee82f
to
fc9c1d4
Compare
f3cd7ee
to
d404b87
Compare
20532f5
to
c22b05d
Compare
This reverts commit c22b05d.
c0a1c71
to
702544f
Compare
a71d89f
to
bebe11b
Compare
jonathanKingston
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/1203822806345703/1209143210450862/f
Description
Whenever there's path change, there's a call to

animateOrTapElement
. This is not a problem for most transitions, but in case of the export button the excessive tapping causes too aggressive UX:This PR ads an internal state called
tapOnce
to the element config, to avoid tapping multiple times for certain elements.Testing Steps
Checklist
Please tick all that apply: