Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new empty PIR package to aid migration #3835

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

THISISDINOSAUR
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR commented Feb 5, 2025

Task/Issue URL: https://app.asana.com/0/1187352151074490/1209334604294772
Tech Design URL:
CC:

Description:
Adds an empty and inert package for now to aid migration. See TD for details

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Test macOS still compiles and runs

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@THISISDINOSAUR THISISDINOSAUR marked this pull request as ready for review February 5, 2025 19:28
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building succeeds, so LGTM. Left minor suggestions re: a copy-paste file header correction.

//
// Package.swift
//
// Copyright © 2023 DuckDuckGo. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright © 2023 DuckDuckGo. All rights reserved.
// Copyright © 2025 DuckDuckGo. All rights reserved.

//
// DataBrokerProtectionBlank.swift
//
// Copyright © 2023 DuckDuckGo. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright © 2023 DuckDuckGo. All rights reserved.
// Copyright © 2025 DuckDuckGo. All rights reserved.

//
// DataBrokerProtectionBlankTests.swift
//
// Copyright © 2023 DuckDuckGo. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright © 2023 DuckDuckGo. All rights reserved.
// Copyright © 2025 DuckDuckGo. All rights reserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants