-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new empty PIR package to aid migration #3835
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building succeeds, so LGTM. Left minor suggestions re: a copy-paste file header correction.
// | ||
// Package.swift | ||
// | ||
// Copyright © 2023 DuckDuckGo. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright © 2023 DuckDuckGo. All rights reserved. | |
// Copyright © 2025 DuckDuckGo. All rights reserved. |
// | ||
// DataBrokerProtectionBlank.swift | ||
// | ||
// Copyright © 2023 DuckDuckGo. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright © 2023 DuckDuckGo. All rights reserved. | |
// Copyright © 2025 DuckDuckGo. All rights reserved. |
// | ||
// DataBrokerProtectionBlankTests.swift | ||
// | ||
// Copyright © 2023 DuckDuckGo. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright © 2023 DuckDuckGo. All rights reserved. | |
// Copyright © 2025 DuckDuckGo. All rights reserved. |
Task/Issue URL: https://app.asana.com/0/1187352151074490/1209334604294772
Tech Design URL:
CC:
Description:
Adds an empty and inert package for now to aid migration. See TD for details
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation