Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new empty PIR package to aid migration #3835

Merged
merged 9 commits into from
Feb 6, 2025
2 changes: 2 additions & 0 deletions DuckDuckGo-macOS.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -4469,6 +4469,7 @@
9D84E3F42CD4E6660046CD8B /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
9D84E43C2CD4E66F0046CD8B /* DBPE2ETests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = DBPE2ETests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
9D8FA00B2AC5BDCE005DD0D0 /* LoginItem+DataBrokerProtection.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "LoginItem+DataBrokerProtection.swift"; sourceTree = "<group>"; };
9D9150F32D53F1F1005B5833 /* DataBrokerProtectionShared */ = {isa = PBXFileReference; lastKnownFileType = wrapper; path = DataBrokerProtectionShared; sourceTree = "<group>"; };
9D9AE8682AA76CDC0026E7DC /* LoginItem+NetworkProtection.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "LoginItem+NetworkProtection.swift"; sourceTree = "<group>"; };
9D9AE86A2AA76CF90026E7DC /* LoginItemsManager.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoginItemsManager.swift; sourceTree = "<group>"; };
9D9AE8D12AAA39A70026E7DC /* DuckDuckGo Personal Information Removal.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "DuckDuckGo Personal Information Removal.app"; sourceTree = BUILT_PRODUCTS_DIR; };
Expand Down Expand Up @@ -6220,6 +6221,7 @@
9D9DE5712C63A96400D20B15 /* AppKitExtensions */,
7B9167A82C09E88800322310 /* AppLauncher */,
378E279D2970217400FCADA2 /* BuildToolPlugins */,
9D9150F32D53F1F1005B5833 /* DataBrokerProtectionShared */,
3192A2702A4C4E330084EA89 /* DataBrokerProtection */,
7B8FDD1E2CDD877000720907 /* FeatureFlags */,
9DF2DB592C73B52F0025F43C /* Freemium */,
Expand Down
2 changes: 2 additions & 0 deletions LocalPackages/DataBrokerProtection/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "236.0.0"),
.package(path: "../DataBrokerProtectionShared"),
.package(path: "../SwiftUIExtensions"),
.package(path: "../AppKitExtensions"),
.package(path: "../XPCHelper"),
Expand All @@ -40,6 +41,7 @@ let package = Package(
name: "DataBrokerProtection",
dependencies: [
.product(name: "BrowserServicesKit", package: "BrowserServicesKit"),
.product(name: "DataBrokerProtectionShared", package: "DataBrokerProtectionShared"),
.product(name: "SwiftUIExtensions", package: "SwiftUIExtensions"),
.product(name: "AppKitExtensions", package: "AppKitExtensions"),
.byName(name: "XPCHelper"),
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>IDEDidComputeMac32BitWarning</key>
<true/>
</dict>
</plist>
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1520"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
shouldAutocreateTestPlan = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "DataBrokerProtectionTests"
BuildableName = "DataBrokerProtectionTests"
BlueprintName = "DataBrokerProtectionTests"
ReferencedContainer = "container:">
</BuildableReference>
</TestableReference>
</Testables>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
70 changes: 70 additions & 0 deletions LocalPackages/DataBrokerProtectionShared/Package.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
// swift-tools-version: 5.7
// The swift-tools-version declares the minimum version of Swift required to build this package.
//
// Package.swift
//
// Copyright © 2025 DuckDuckGo. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

import PackageDescription

let package = Package(
name: "DataBrokerProtectionShared",
platforms: [ .macOS("11.4") ],
products: [
.library(
name: "DataBrokerProtectionShared",
targets: ["DataBrokerProtectionShared"])
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "236.0.0"),
.package(path: "../SwiftUIExtensions"),
.package(path: "../AppKitExtensions"),
.package(path: "../XPCHelper"),
.package(path: "../Freemium"),
],
targets: [
.target(
name: "DataBrokerProtectionShared",
dependencies: [
.product(name: "BrowserServicesKit", package: "BrowserServicesKit"),
.product(name: "SwiftUIExtensions", package: "SwiftUIExtensions"),
.product(name: "AppKitExtensions", package: "AppKitExtensions"),
.byName(name: "XPCHelper"),
.product(name: "PixelKit", package: "BrowserServicesKit"),
.product(name: "Configuration", package: "BrowserServicesKit"),
.product(name: "Persistence", package: "BrowserServicesKit"),
.product(name: "Freemium", package: "Freemium"),
],
resources: [.copy("Resources")],
swiftSettings: [
.define("DEBUG", .when(configuration: .debug))
]
),
.testTarget(
name: "DataBrokerProtectionSharedTests",
dependencies: [
"DataBrokerProtectionShared",
"BrowserServicesKit",
"Freemium",
.product(name: "PersistenceTestingUtils", package: "BrowserServicesKit"),
.product(name: "SubscriptionTestingUtilities", package: "BrowserServicesKit"),
],
resources: [
.copy("Resources")
]
)
]
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//
// DataBrokerProtectionBlank.swift
//
// Copyright © 2025 DuckDuckGo. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

import Foundation
17 changes: 17 additions & 0 deletions LocalPackages/DataBrokerProtectionShared/Tests/.swiftlint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
disabled_rules:
- file_length
- unused_closure_parameter
- type_name
- force_cast
- force_try
- function_body_length
- cyclomatic_complexity
- identifier_name
- blanket_disable_command
- type_body_length
- explicit_non_final_class
- enforce_os_log_wrapper

large_tuple:
warning: 6
error: 10
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//
// DataBrokerProtectionBlankTests.swift
//
// Copyright © 2025 DuckDuckGo. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

import Foundation
Loading