Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Review: VPN App Exclusions #3850

Merged
merged 13 commits into from
Feb 12, 2025
Merged

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 7, 2025

Task/Issue URL: https://app.asana.com/0/1142021229838617/1209157524718919

Description:

Releases VPN App Exclusions for macOS.

Steps to test this PR:

  1. Use the privacy config from Ship Review: VPN App Exclusions privacy-configuration#2742
  2. Ensure your app version is at least 1.127.0 (modify manually if needed).
  3. Ensure the feature is visible.
  4. Ensure the feature is not visible if your app version is 1.126.0.
  5. Start the VPN and test App Exclusions by excluding Chrome, and searching "What is my IP address on it"

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez self-assigned this Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 817f968

Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!
I think there are some issues with the string (I dunno why but some are reported as “needs review”.
Screenshot 2025-02-12 at 10 29 59

if you go to localizable dictionary you can sort the string by state (for each language and mark them as “reviewed” you can also remove the stale one since it should not be in use

Can you please fix this before merging? (I assume this is why some strings get reintroduced in translation… I am not sure why it does that)

@diegoreymendez diegoreymendez merged commit 916fd10 into main Feb 12, 2025
20 checks passed
@diegoreymendez diegoreymendez deleted the diego/app-exclusions-ship-review branch February 12, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants