-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship Review: VPN App Exclusions #3850
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
I think there are some issues with the string (I dunno why but some are reported as “needs review”.
if you go to localizable dictionary you can sort the string by state (for each language and mark them as “reviewed” you can also remove the stale one since it should not be in use
Can you please fix this before merging? (I assume this is why some strings get reintroduced in translation… I am not sure why it does that)
Task/Issue URL: https://app.asana.com/0/1142021229838617/1209157524718919
Description:
Releases VPN App Exclusions for macOS.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation