Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Review: VPN App Exclusions #2742

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

diegoreymendez
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/1142021229838617/1209157524718919

macOS PR: duckduckgo/macos-browser#3850

Description

Releases App Exclusions for the VPN.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

Bunn
Bunn previously approved these changes Feb 11, 2025
Copy link

Generated file outputs:

Time updated: Wed, 12 Feb 2025 12:27:37 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -6658,9 +6658,10 @@
                 "enforceRoutes": {
                     "state": "enabled"
                 },
                 "appExclusions": {
-                    "state": "disabled"
+                    "state": "enabled",
+                    "minSupportedVersion": "1.127.0"
                 }
             },
             "exceptions": [],
             "minSupportedVersion": "1.57.1"
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6145,9 +6145,10 @@
                 "enforceRoutes": {
                     "state": "enabled"
                 },
                 "appExclusions": {
-                    "state": "disabled"
+                    "state": "enabled",
+                    "minSupportedVersion": "1.127.0"
                 }
             },
             "exceptions": [],
             "minSupportedVersion": "1.57.1"

@diegoreymendez diegoreymendez added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit bd493eb Feb 12, 2025
9 checks passed
@diegoreymendez diegoreymendez deleted the diego/app-exclusions-ship-review branch February 12, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants