Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Default to expanded favorites NTP section if setting is not present #3858

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Feb 11, 2025

Task/Issue URL: https://app.asana.com/0/1201048563534612/1209373805889971

Description:
This change ensures that if a user never updated NTP favorites expanded state setting, they will see
expanded favorites on NTP.

Steps to test this PR:

  1. Run the app and import bookmarks. Ensure that you have more than 6 favorites.
  2. On New Tab Page, collapse favorites section so that it displays only 6 favorites.
  3. Close the app.
  4. Delete settings:
defaults delete com.duckduckgo.macos.browser.debug new-tab-page.favorites.is-view-expanded # new, migrated setting
defaults delete com.duckduckgo.macos.browser.debug home.page.show.all.favorites # old setting
  1. Run the app and verify that all favorites are displayed.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from alessandroboron February 11, 2025 07:17
@ayoy ayoy requested review from diegoreymendez and removed request for alessandroboron February 11, 2025 07:47
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a powerful boolean. Works as described.

@ayoy ayoy merged commit 6618716 into hotfix/1.125.1 Feb 11, 2025
31 of 33 checks passed
@ayoy ayoy deleted the dominik/fix-favorites-initial-state branch February 11, 2025 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants