Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cyclic references in shared_ptr [15831] #174

Merged
merged 9 commits into from
Oct 26, 2022
Merged

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 6, 2022

This PR fixes a cycle between shared ptrs that implies memory leaks.

Pending to:

  • Add doxygen
  • Check ASAN in all tests
  • Check ASAN in dump/load
  • Add specific fragil_ptr tests (Im afraid not gonna happen)

Merge after:

@jparisu jparisu force-pushed the fix/cyclic-shared branch from 9a900a5 to e5c97dc Compare October 6, 2022 13:52
@jparisu jparisu force-pushed the fix/cyclic-shared branch from e5c97dc to 8d671dd Compare October 6, 2022 14:29
@jparisu jparisu marked this pull request as ready for review October 6, 2022 14:29
@jparisu jparisu force-pushed the fix/cyclic-shared branch from 8d671dd to 123a419 Compare October 7, 2022 10:07
@jparisu jparisu temporarily deployed to codecov October 14, 2022 11:04 Inactive
@jparisu jparisu changed the title Fix cyclic references in shared_ptr Fix cyclic references in shared_ptr [15831] Oct 24, 2022
@MiguelCompany
Copy link
Member

@jparisu Please rebase and fix conflicts here

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review: fragile_ptr template

@MiguelCompany
Copy link
Member

@jparisu Please rebase

@jparisu jparisu temporarily deployed to codecov October 25, 2022 05:23 Inactive
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 58.08% // Head: 58.15% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (85425b4) compared to base (04e66d5).
Patch coverage: 96.49% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   58.08%   58.15%   +0.06%     
==========================================
  Files          32       33       +1     
  Lines        4345     4364      +19     
  Branches     2318     2322       +4     
==========================================
+ Hits         2524     2538      +14     
+ Misses         59       57       -2     
- Partials     1762     1769       +7     
Impacted Files Coverage Δ
...fastdds_statistics_backend/exception/Exception.hpp 50.00% <ø> (ø)
src/cpp/database/entities.hpp 100.00% <ø> (ø)
src/cpp/exception/Exception.cpp 87.50% <ø> (-1.98%) ⬇️
src/cpp/database/database.hpp 64.70% <75.00%> (-0.36%) ⬇️
src/cpp/types/fragile_ptr.hpp 97.87% <97.87%> (ø)
src/cpp/StatisticsBackendData.cpp 62.42% <100.00%> (ø)
src/cpp/database/entities.cpp 95.74% <100.00%> (ø)
src/cpp/database/database.cpp 51.30% <0.00%> (-0.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov October 25, 2022 13:57 Inactive
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just uncrustify and we're done

Signed-off-by: jparisu <[email protected]>
@jparisu jparisu temporarily deployed to codecov October 26, 2022 05:43 Inactive
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 514b5f2 into main Oct 26, 2022
@MiguelCompany MiguelCompany deleted the fix/cyclic-shared branch October 26, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants