-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cyclic references in shared_ptr [15831] #174
Conversation
9a900a5
to
e5c97dc
Compare
e5c97dc
to
8d671dd
Compare
8d671dd
to
123a419
Compare
1bbf629
to
34a7e1f
Compare
34a7e1f
to
8c72b18
Compare
8c72b18
to
4d6a39d
Compare
4d6a39d
to
241b54e
Compare
241b54e
to
7b8d563
Compare
7b8d563
to
a3cf902
Compare
2e56dca
to
e072c7b
Compare
@jparisu Please rebase and fix conflicts here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review: fragile_ptr template
@jparisu Please rebase |
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
b8f5494
to
cf98c1d
Compare
Codecov ReportBase: 58.08% // Head: 58.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 58.08% 58.15% +0.06%
==========================================
Files 32 33 +1
Lines 4345 4364 +19
Branches 2318 2322 +4
==========================================
+ Hits 2524 2538 +14
+ Misses 59 57 -2
- Partials 1762 1769 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: jparisu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just uncrustify and we're done
Signed-off-by: jparisu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes a cycle between shared ptrs that implies memory leaks.
Pending to:
Merge after: