This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
ISAICP-5599: Do not run sparql_entity_storage tests anymore. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idimopoulos
force-pushed
the
ISAICP-5599
branch
from
f27736e to
31031f7
Compare
| @@ -14,7 +14,6 @@ | |||
| "drupal/sparql_entity_storage": "^1.0" | |||
| }, | |||
| "require-dev": { | |||
| "minimaxir/big-list-of-naughty-strings": "dev-master", | |||
There was a problem hiding this comment.
Why is this removed? EDIT: I see, is tested in the other module.
| @@ -12,9 +12,6 @@ case "${TEST}" in | |||
| PHPCodeSniffer) | |||
| cd ${TRAVIS_BUILD_DIR} | |||
| composer install | |||
| # This is a temporary hack until the tests for SPARQL Entity Storage | |||
| # module are enable din their project repo. | |||
| mv ./vendor/drupal/sparql_entity_storage ./modules/ | |||
There was a problem hiding this comment.
There's a PHPStan job line https://github.com/ec-europa/rdf_entity/blob/8.x-1.x/tests/travis-ci/scripts/run_tests.sh#L27 that also refers to sparql_entity_storage
claudiu-cristea
suggested changes
Jan 19, 2021
idimopoulos
force-pushed
the
ISAICP-5599
branch
from
316b29c to
31031f7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.