ISAICP-5599: Do not run sparql_entity_storage tests anymore.

composer.json

@@ -14,7 +14,6 @@
     "drupal/sparql_entity_storage": "^1.0"
   },
   "require-dev": {
-    "minimaxir/big-list-of-naughty-strings": "dev-master",
     "drupal/coder": "^8.3",
     "easyrdf/easyrdf": "1.0.0 as 0.9.2",
     "mglaman/phpstan-drupal": "^0.12.6",
@@ -24,17 +23,6 @@
     {
       "type": "composer",
       "url": "https://packages.drupal.org/8"
-    },
-    {
-      "type": "package",
-      "package": {
-        "name": "minimaxir/big-list-of-naughty-strings",
-        "version": "dev-master",
-        "dist": {
-          "url": "https://github.com/minimaxir/big-list-of-naughty-strings/archive/master.zip",
-          "type": "zip"
-        }
-      }
     }
   ]
 }

modules/rdf_draft/rdf_draft.install

@@ -5,6 +5,8 @@
  * Includes installation functions for the rdf_draft module.
  */
 
+declare(strict_types = 1);
+
 use Drupal\Core\Serialization\Yaml;
 use Drupal\sparql_entity_storage\Entity\SparqlGraph;
 use Drupal\sparql_entity_storage\SparqlGraphInterface;

modules/rdf_draft/rdf_draft.module

@@ -5,6 +5,8 @@
  * Procedural lumps of code for the rdf_draft module.
  */
 
+declare(strict_types = 1);
+
 use Drupal\Core\Entity\EntityInterface;
 use Drupal\sparql_entity_storage\SparqlEntityStorageInterface;
 use Drupal\sparql_entity_storage\SparqlGraphInterface;

modules/rdf_draft/src/Controller/RdfController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_draft\Controller;
 
 use Drupal\Core\Controller\ControllerBase;

modules/rdf_draft/src/EventSubscriber/ActiveGraphSubscriber.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_draft\EventSubscriber;
 
 use Drupal\Core\Entity\EntityTypeManagerInterface;

modules/rdf_draft/src/RdfGraphAccessCheck.php

@@ -9,9 +9,9 @@
 use Drupal\Core\Entity\EntityTypeManagerInterface;
 use Drupal\Core\Extension\ModuleHandlerInterface;
 use Drupal\Core\Session\AccountInterface;
+use Drupal\rdf_entity\RdfInterface;
 use Drupal\sparql_entity_storage\SparqlEntityStorage;
 use Drupal\sparql_entity_storage\SparqlGraphInterface;
-use Drupal\rdf_entity\RdfInterface;
 use Symfony\Component\Routing\Route;
 
 /**
@@ -67,7 +67,7 @@ public function access(Route $route, AccountInterface $account, RdfInterface $rd
     // Check if there is an entity saved in the passed graph.
     $entity = $storage->load($rdf_entity->id(), [$graph]);
 
-    // @todo: When the requested graph is the only one and it is not the
+    // @todo When the requested graph is the only one and it is not the
     // default, it is loaded in the default view, so maybe there is no need
     // to also show a separate tab.
     return AccessResult::allowedIf($entity && $this->checkAccess($rdf_entity, $route, $account, $operation, $graph))->cachePerPermissions()->addCacheableDependency($rdf_entity);
@@ -92,9 +92,9 @@ public function checkAccess(EntityInterface $entity, Route $route, AccountInterf
       return FALSE;
     }
 
-    // @todo: This probably needs to be cached manually creating a cid.
+    // @todo This probably needs to be cached manually creating a cid.
     // @see: \Drupal\node\Access\NodeRevisionAccessCheck::checkAccess().
-    // @todo: This needs also to check cache for cached permission.
+    // @todo This needs also to check cache for cached permission.
     // @see: \Drupal\Core\Entity\EntityAccessControlHandler::access().
     $has_permission = $account->hasPermission($map[$operation]) || $account->hasPermission($type_map[$operation]);
     $access = $has_permission ? AccessResult::allowed() : AccessResult::neutral();

modules/rdf_draft/src/RdfGraphAccessCheckInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_draft;
 
 use Drupal\Core\Entity\EntityInterface;

modules/rdf_draft/src/RdfGraphPermissions.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_draft;
 
 use Drupal\Core\DependencyInjection\ContainerInjectionInterface;

modules/rdf_draft/src/Routing/RouteSubscriber.php

@@ -8,6 +8,7 @@
 use Drupal\Core\Entity\EntityTypeManagerInterface;
 use Drupal\Core\Routing\RouteSubscriberBase;
 use Drupal\Core\Routing\RoutingEvents;
+use Drupal\Core\StringTranslation\StringTranslationTrait;
 use Drupal\sparql_entity_storage\SparqlEntityStorage;
 use Symfony\Component\Routing\Route;
 use Symfony\Component\Routing\RouteCollection;
@@ -17,6 +18,8 @@
  */
 class RouteSubscriber extends RouteSubscriberBase {
 
+  use StringTranslationTrait;
+
   /**
    * The entity type manager service.
    *
@@ -73,7 +76,7 @@ protected function getRdfGraphRoute(EntityTypeInterface $entity_type, array $gra
       $route
         ->addDefaults([
           '_controller' => '\Drupal\rdf_draft\Controller\RdfController::view',
-          '_title' => (string) t('View @title', ['@title' => (string) $graph_definition['title']]),
+          '_title' => (string) $this->t('View @title', ['@title' => (string) $graph_definition['title']]),
         ])
         ->addRequirements([
           '_access_rdf_graph' => 'TRUE',

modules/rdf_export/src/Controller/RdfExportController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_export\Controller;
 
 use Drupal\Core\Controller\ControllerBase;

modules/rdf_export/src/Form/SettingsForm.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_export\Form;
 
 use Drupal\Core\Form\ConfigFormBase;
@@ -32,7 +34,7 @@ public function getFormId() {
    */
   public function buildForm(array $form, FormStateInterface $form_state) {
     $export_types = $this->config('rdf_export.settings')->get('export_types');
-    // @todo: Check which format are supported by the server?
+    // @todo Check which format are supported by the server?
     $formats = Format::getFormats();
     $list = [];
     /** @var \EasyRdf\Format $format */
@@ -44,11 +46,11 @@ public function buildForm(array $form, FormStateInterface $form_state) {
 
     $form['export_types'] = [
       '#type' => 'select',
-      '#title' => t('Export types'),
+      '#title' => $this->t('Export types'),
       '#options' => $list,
       '#multiple' => TRUE,
       '#default_value' => empty($export_types) ? [] : $export_types,
-      '#description' => t('Select the export types for rdf entities.'),
+      '#description' => $this->t('Select the export types for rdf entities.'),
     ];
 
     return parent::buildForm($form, $form_state);

modules/rdf_export/tests/src/Functional/RdfExportTest.php

@@ -1,10 +1,12 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\Tests\rdf_export\Functional;
 
-use Drupal\rdf_entity\Entity\Rdf;
 use Drupal\Tests\BrowserTestBase;
 use Drupal\Tests\sparql_entity_storage\Traits\SparqlConnectionTrait;
+use Drupal\rdf_entity\Entity\Rdf;
 
 /**
  * Tests the RDF export functionality.

modules/rdf_taxonomy/rdf_taxonomy.install

@@ -5,6 +5,8 @@
  * Install rdf taxonomy.
  */
 
+declare(strict_types = 1);
+
 use Drupal\Core\Field\BaseFieldDefinition;
 use Drupal\Core\StringTranslation\TranslatableMarkup;
 use Drupal\rdf_taxonomy\Entity\RdfTerm;

modules/rdf_taxonomy/rdf_taxonomy.module

@@ -5,16 +5,18 @@
  * Main functions and hook implementations of the RDF Taxonomy module.
  */
 
+declare(strict_types = 1);
+
 use Drupal\Core\Access\AccessResult;
 use Drupal\Core\Entity\EntityTypeInterface;
 use Drupal\Core\Field\BaseFieldDefinition;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Session\AccountInterface;
-use Drupal\sparql_entity_storage\Entity\Query\Sparql\SparqlArg;
-use Drupal\sparql_entity_storage\Entity\SparqlMapping;
 use Drupal\rdf_taxonomy\Entity\RdfTerm;
 use Drupal\rdf_taxonomy\RdfTaxonomyTermListBuilder;
 use Drupal\rdf_taxonomy\TermRdfStorage;
+use Drupal\sparql_entity_storage\Entity\Query\Sparql\SparqlArg;
+use Drupal\sparql_entity_storage\Entity\SparqlMapping;
 use Drupal\sparql_entity_storage\UriEncoder;
 use Drupal\taxonomy\Entity\Term;
 use Drupal\taxonomy\Entity\Vocabulary;

modules/rdf_taxonomy/src/Entity/RdfTerm.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_taxonomy\Entity;
 
 use Drupal\Core\Entity\EntityTypeInterface;

modules/rdf_taxonomy/src/EventSubscriber/OutboundTermParentSubscriber.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_taxonomy\EventSubscriber;
 
 use Drupal\sparql_entity_storage\Event\OutboundValueEvent;

modules/rdf_taxonomy/src/RdfTaxonomyConfigOverrides.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_taxonomy;
 
 use Drupal\Core\Cache\CacheableMetadata;

modules/rdf_taxonomy/src/RdfTaxonomyTermListBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_taxonomy;
 
 use Drupal\Core\Entity\EntityInterface;

modules/rdf_taxonomy/src/Routing/RouteSubscriber.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_taxonomy\Routing;
 
 use Drupal\Core\Routing\RouteSubscriberBase;

modules/rdf_taxonomy/src/TermRdfStorage.php

@@ -227,7 +227,7 @@ protected function alterGraph(Graph &$graph, EntityInterface $entity): void {
   /**
    * {@inheritdoc}
    */
-  public function resetCache(array $ids = NULL, array $graph_ids = NULL): void {
+  public function resetCache(?array $ids = NULL, ?array $graph_ids = NULL): void {
     drupal_static_reset('taxonomy_term_count_nodes');
     $this->parents = [];
     $this->parentsAll = [];

modules/rdf_taxonomy/tests/src/Functional/ManageUnlockedVocabularyTermsTest.php

@@ -1,12 +1,14 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\Tests\rdf_taxonomy\Functional;
 
+use Drupal\Tests\BrowserTestBase;
+use Drupal\Tests\sparql_entity_storage\Traits\SparqlConnectionTrait;
 use Drupal\filter\Entity\FilterFormat;
 use Drupal\sparql_entity_storage\Entity\SparqlMapping;
 use Drupal\taxonomy\Entity\Vocabulary;
-use Drupal\Tests\BrowserTestBase;
-use Drupal\Tests\sparql_entity_storage\Traits\SparqlConnectionTrait;
 
 /**
  * Tests adding, editing and deleting terms in an unlocked vocabulary.

modules/rdf_taxonomy/tests/src/Kernel/SparqlTaxonomyTest.php

@@ -4,8 +4,8 @@
 
 namespace Drupal\rdf_taxonomy\Tests;
 
-use Drupal\taxonomy\Entity\Term;
 use Drupal\Tests\rdf_entity\Kernel\RdfKernelTestBase;
+use Drupal\taxonomy\Entity\Term;
 
 /**
  * Tests Entity Query functionality of the Sparql backend.

modules/rdf_taxonomy/tests/src/Kernel/SparqlTermWeightTest.php

@@ -5,10 +5,10 @@
 namespace Drupal\Tests\rdf_taxonomy\Kernel;
 
 use Drupal\KernelTests\KernelTestBase;
+use Drupal\Tests\sparql_entity_storage\Traits\SparqlConnectionTrait;
 use Drupal\rdf_taxonomy\Entity\RdfTerm;
 use Drupal\sparql_entity_storage\Entity\SparqlMapping;
 use Drupal\taxonomy\Entity\Vocabulary;
-use Drupal\Tests\sparql_entity_storage\Traits\SparqlConnectionTrait;
 
 /**
  * Tests the RdfTerm weight.

rdf_entity.install

@@ -5,6 +5,8 @@
  * Includes installation functions for the rdf_entity module.
  */
 
+declare(strict_types = 1);
+
 use Drupal\Core\Field\BaseFieldDefinition;
 use Drupal\Core\Serialization\Yaml;
 use Drupal\sparql_entity_storage\Entity\SparqlGraph;

src/ContextProvider/RdfEntityRouteContext.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_entity\ContextProvider;
 
 use Drupal\Core\Cache\CacheableMetadata;

src/Controller/RdfController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_entity\Controller;
 
 use Drupal\Component\Utility\Xss;

src/Entity/Controller/RdfTypeListBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_entity\Entity\Controller;
 
 use Drupal\Core\Config\Entity\ConfigEntityListBuilder;
@@ -17,9 +19,9 @@ class RdfTypeListBuilder extends ConfigEntityListBuilder {
    * {@inheritdoc}
    */
   public function buildHeader() {
-    $header['title'] = t('Name');
+    $header['title'] = $this->t('Name');
     $header['description'] = [
-      'data' => t('Description'),
+      'data' => $this->t('Description'),
       'class' => [RESPONSIVE_PRIORITY_MEDIUM],
     ];
     return $header + parent::buildHeader();

src/Entity/Rdf.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\rdf_entity\Entity;
 
 use Drupal\Core\Entity\ContentEntityBase;
@@ -268,14 +270,14 @@ public function isPublished() {
    * {@inheritdoc}
    */
   public function setPublished($published = NULL) {
-    // TODO: Implement setPublished() method.
+    // @todo Implement setPublished() method.
   }
 
   /**
    * {@inheritdoc}
    */
   public function setUnpublished() {
-    // TODO: Implement setUnpublished() method.
+    // @todo Implement setUnpublished() method.
   }
 
   /**
@@ -368,7 +370,7 @@ public function hasGraph($graph) {
   /**
    * {@inheritdoc}
    */
-  public static function load($id, array $graph_ids = NULL) {
+  public static function load($id, ?array $graph_ids = NULL) {
     $entity_type_repository = \Drupal::service('entity_type.repository');
     $entity_type_manager = \Drupal::entityTypeManager();
     /** @var \Drupal\sparql_entity_storage\SparqlEntityStorageInterface $storage */
@@ -379,7 +381,7 @@ public static function load($id, array $graph_ids = NULL) {
   /**
    * {@inheritdoc}
    */
-  public static function loadMultiple(array $ids = NULL, array $graph_ids = NULL) {
+  public static function loadMultiple(?array $ids = NULL, ?array $graph_ids = NULL) {
     $entity_type_repository = \Drupal::service('entity_type.repository');
     $entity_type_manager = \Drupal::entityTypeManager();
     /** @var \Drupal\sparql_entity_storage\SparqlEntityStorageInterface $storage */