Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#56] Introduce from_bytes_truncated #57

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 25, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #56

@elfenpiff elfenpiff requested a review from elBoberido December 25, 2023 02:16
@elfenpiff elfenpiff self-assigned this Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8cb41f) 77.89% compared to head (f7a9966) 77.93%.
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   77.89%   77.93%   +0.03%     
==========================================
  Files         172      172              
  Lines       18664    18690      +26     
==========================================
+ Hits        14539    14566      +27     
+ Misses       4125     4124       -1     
Files Coverage Δ
iceoryx2-bb/container/src/byte_string.rs 90.96% <100.00%> (+0.30%) ⬆️
iceoryx2-bb/posix/src/mutex.rs 61.23% <ø> (+0.30%) ⬆️

... and 3 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-56-add-from-bytes-truncated branch from face950 to dc84df5 Compare December 25, 2023 11:41
@elfenpiff elfenpiff mentioned this pull request Dec 25, 2023
17 tasks
@elfenpiff elfenpiff force-pushed the iox2-56-add-from-bytes-truncated branch from bc6cc22 to f7a9966 Compare December 27, 2023 23:30
@elfenpiff elfenpiff requested a review from elBoberido December 28, 2023 00:16
@elfenpiff elfenpiff merged commit b9f6f66 into eclipse-iceoryx:main Dec 29, 2023
19 of 20 checks passed
@elfenpiff elfenpiff deleted the iox2-56-add-from-bytes-truncated branch December 29, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add from_bytes_truncated to FixedSizeByteString
2 participants