Add remaining ValueTypeTests for lw5 #18505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
project:valhalla
theresa-m
force-pushed
the
valuetypetests_5
branch
2 times, most recently
from
45a1669 to
eae6f8a
Compare
theresa-m
changed the title
hangshao0
reviewed
Nov 22, 2023
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
- move attributes to ValhallaUtils - remove testValueTypeClassWithImplicitCreationAttribute since there are now uses of ImplicitAttribute in ValueTypeTests Signed-off-by: Theresa Mammarella <[email protected]>
All are passing except for testDefaultValueIn*Array tests, vm changes coming for this in a seperate pull request. The next step after this is to update my local lw5 to where aconst_init and withfield to update the rest of the tests. Not added to lw5: testDefaultValueWithNonValueType - testing runtime check for aconst_init testMethodTypeDescriptorRef - testing change for qtypes testMethodTypeDescriptorValue - testing change for qtypes testUnresolvedDefaultValueUse - aconst_init test testUnresolvedWithFieldUse - withfield test testPrimitiveClassHashCode testCheckCastValueTypeOnInvalidQtype Rename testCheckCastValueTypeOnInvalidLtype -> testCheckCastValueTypeOnInvalidClass testCheckCastValueTypeOnNull - doesn't apply to nullrestricted testDefaultValueInPointByteCodeMultiArray testDefaultValueInLineByteCodeMultiArray testDefaultValueInTriangleByteCodeMultiArray Rename ValueTypeGenerator.generateIllegalValueClassWithSychMethods tp ValueTypeGenerator.generateIllegalValueClassWithSynchMethods Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
valuetypetests_5
branch
from
eae6f8a to
b3b3f4a
Compare
hangshao0
reviewed
Nov 23, 2023
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
theresa-m
force-pushed
the
valuetypetests_5
branch
from
b3b3f4a to
29315de
Compare
theresa-m
force-pushed
the
valuetypetests_5
branch
from
29315de to
ad8b584
Compare
|
There are line ending check failures. |
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
valuetypetests_5
branch
from
ad8b584 to
ad40a92
Compare
hangshao0
approved these changes
Nov 23, 2023
|
Jenkins test sanity,extended winval jdknext |
|
Jenkins test sanity,extended aixval jdknext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this is a big one. All ValueTypeTests with lw5 are passing except for testDefaultValueIn*Array tests, vm changes coming for this in a seperate pull request.
The next step after this is to update my local lw5 to where aconst_init and withfield to update the rest of the tests.
Not added to lw5:
testDefaultValueWithNonValueType - testing runtime check for aconst_init
testMethodTypeDescriptorRef - testing change for qtypes
testMethodTypeDescriptorValue - testing change for qtypes
testUnresolvedDefaultValueUse - aconst_init test
testUnresolvedWithFieldUse - withfield test
testPrimitiveClassHashCode
testCheckCastValueTypeOnInvalidQtype
Rename testCheckCastValueTypeOnInvalidLtype -> testCheckCastValueTypeOnInvalidClass
testCheckCastValueTypeOnNull - doesn't apply to nullrestricted
testDefaultValueInPointByteCodeMultiArray
testDefaultValueInLineByteCodeMultiArray
testDefaultValueInTriangleByteCodeMultiArray
ValhallaAttributeTests.testValueTypeClassWithImplicitCreationAttribute - there are now uses of ImplicitAttribute in ValueTypeTests
Rename ValueTypeGenerator.generateIllegalValueClassWithSychMethods tp ValueTypeGenerator.generateIllegalValueClassWithSynchMethods