Add all SVGs for Platform UI Icons #2643

Michael5601 · 2024-12-20T13:21:11Z

This PR adds SVGs for testing the new SVG feature.

See this PR for the feature.

HeikoKlare

I've just tested the SVG replacement with the recent addition of SVG support to SWT. To do so, I had to add the SVG fragment to the product. Note that this PR needs to be extended by adding the required capability for every bundle using SVGs in order to ensure that products using those bundles have a rasterized available.

I found that some icons are not rasterized in proper resolution but upscaled from 100%. When moving to a 175% monitor (from 100% primary monitor with monitor-specific scaling enabled), I got the following:

In particular, several icons from the org.eclipse.search bundle are not scaled properly in toolbars (probably it also affects others). May this require further changes such as the ones proposed in ...?

Feature Proposal: Rasterization of SVGs at Runtime for Eclipse Icons #2593

github-actions · 2025-03-30T11:17:33Z

Test Results

1 824 files ±0 1 824 suites ±0 1h 37m 50s ⏱️ + 6m 1s
7 918 tests ±0 7 688 ✅ - 1 228 💤 ±0 2 ❌ +1
23 841 runs ±0 23 087 ✅ - 5 748 💤 ±0 6 ❌ +5

For more details on these failures, see this check.

Results for commit f0639c6. ± Comparison against base commit 9730d5f.

♻️ This comment has been updated with latest results.

eclipse-platform-bot · 2025-03-30T11:19:35Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
bundles/org.eclipse.ui/META-INF/MANIFEST.MF
examples/org.eclipse.ui.examples.fieldassist/META-INF/MANIFEST.MF
examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From d4964f64245ed1c6b95af9dcefdfd6c62054bfa3 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sun, 30 Mar 2025 11:19:13 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
index 35c9b4571f..ed6f774523 100644
--- a/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.progress;singleton:=true
-Bundle-Version: 0.4.700.qualifier
+Bundle-Version: 0.4.800.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
index cb4ef940ce..72f376b468 100644
--- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.renderers.swt;singleton:=true
-Bundle-Version: 0.16.700.qualifier
+Bundle-Version: 0.16.800.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
index 35f8df3ddd..6aaad1dff5 100644
--- a/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
@@ -4,7 +4,7 @@ Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-SymbolicName: org.eclipse.jface.notifications
-Bundle-Version: 0.7.300.qualifier
+Bundle-Version: 0.7.400.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Export-Package: org.eclipse.jface.notifications,
  org.eclipse.jface.notifications.internal;x-internal:=true
diff --git a/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF b/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
index 7b5249d26a..f1f70b26c8 100644
--- a/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.ui.refactoring
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.ui.refactoring; singleton:=true
-Bundle-Version: 3.13.500.qualifier
+Bundle-Version: 3.13.600.qualifier
 Bundle-Activator: org.eclipse.ltk.internal.ui.refactoring.RefactoringUIPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
index 9a63a5630f..5e46a06a14 100644
--- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
-Bundle-Version: 3.19.100.qualifier
+Bundle-Version: 3.19.200.qualifier
 Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
index 31a9a9c320..6f5dd6b08a 100644
--- a/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.ui.genericeditor;singleton:=true
-Bundle-Version: 1.3.500.qualifier
+Bundle-Version: 1.3.600.qualifier
 Bundle-Vendor: %Bundle-Vendor
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.ui.workbench.texteditor;bundle-version="3.10.0",
diff --git a/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
index 2a8197c69e..98a8744054 100644
--- a/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.ide.application;singleton:=true
-Bundle-Version: 1.5.600.qualifier
+Bundle-Version: 1.5.700.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.ui.ide;bundle-version="[3.21.0,4.0.0)",
diff --git a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
index 52eee57bc2..c93617cfe9 100644
--- a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator.resources; singleton:=true
-Bundle-Version: 3.9.600.qualifier
+Bundle-Version: 3.9.700.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.resources.plugin.WorkbenchNavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
diff --git a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
index 5b07fee8ce..f1bfb949ac 100644
--- a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.ui.views.log;singleton:=true
-Bundle-Version: 1.4.700.qualifier
+Bundle-Version: 1.4.800.qualifier
 Bundle-Activator: org.eclipse.ui.internal.views.log.Activator
 Bundle-Vendor: %provider-name
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
diff --git a/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
index 7e7edf06b3..a370894118 100644
--- a/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.views/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.views; singleton:=true
-Bundle-Version: 3.12.500.qualifier
+Bundle-Version: 3.12.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.ui.internal.views.contentoutline;x-internal:=true,
diff --git a/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
index 2e7b7c5380..1115872cdf 100644
--- a/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.workbench.texteditor; singleton:=true
-Bundle-Version: 3.19.100.qualifier
+Bundle-Version: 3.19.200.qualifier
 Bundle-Activator: org.eclipse.ui.internal.texteditor.TextEditorPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.ui/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui/META-INF/MANIFEST.MF
index 61b1d80377..e4180b1e14 100644
--- a/bundles/org.eclipse.ui/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui; singleton:=true
-Bundle-Version: 3.207.100.qualifier
+Bundle-Version: 3.207.200.qualifier
 Bundle-Activator: org.eclipse.ui.internal.UIPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %Plugin.providerName
diff --git a/examples/org.eclipse.ui.examples.fieldassist/META-INF/MANIFEST.MF b/examples/org.eclipse.ui.examples.fieldassist/META-INF/MANIFEST.MF
index 623cff7dc8..0b19ff5836 100644
--- a/examples/org.eclipse.ui.examples.fieldassist/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.ui.examples.fieldassist/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.examples.fieldassist; singleton:=true
-Bundle-Version: 1.3.200.qualifier
+Bundle-Version: 1.3.300.qualifier
 Bundle-Activator: org.eclipse.ui.examples.fieldassist.FieldAssistPlugin
 Bundle-Localization: plugin
 Bundle-Vendor: %Bundle-Vendor
diff --git a/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF b/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
index 9f67ea8815..c7e8f19d77 100644
--- a/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.examples.javaeditor; singleton:=true
-Bundle-Version: 3.4.400.qualifier
+Bundle-Version: 3.4.500.qualifier
 Bundle-Activator: org.eclipse.ui.examples.javaeditor.JavaEditorExamplePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Michael5601 · 2025-03-31T13:31:13Z

Note that this PR needs to be extended by adding the required capability for every bundle using SVGs in order to ensure that products using those bundles have a rasterized available.

I updated the all manifests of bundles where I added SVGs with Require-Capability.

I found that some icons are not rasterized in proper resolution but upscaled from 100%. When moving to a 175% monitor (from 100% primary monitor with monitor-specific scaling enabled), I got the following:

I tried loading the SVGs on 125% and 175% zoom respectively and it worked fine without blurry icons. Then I reproduced your setup with activated monitor-specific UI scaling and it also works fine. Can you please try again if the issue still persists and if so, can you maybe tell me how I can reproduce the problem?

May this require further changes such as the ones proposed in ...?

As as all the icons of org.eclipse.search are loaded with the URLImageFileNameProvider I am pretty sure the proposed changes in Platform UI have no impact here as they only adjust the URLImageDataProvider (and FileImageDescriptor).

HeikoKlare · 2025-04-03T10:45:51Z

I tried loading the SVGs on 125% and 175% zoom respectively and it worked fine without blurry icons. Then I reproduced your setup with activated monitor-specific UI scaling and it also works fine. Can you please try again if the issue still persists and if so, can you maybe tell me how I can reproduce the problem?

With the following setup, I can still reproduce it:

Use monitor-specific scaling (which is now enabled by default anyway, so if you have an up-to-date IDE, that will be used automatically)
Two monitors: primary monitor at 100% and secondary at 175%

When moving the windows to the secondary monitor, the marked icons are blurry.

HeikoKlare · 2025-04-03T18:48:31Z

You can ignore my previous comment. I found the issue for the wrongly scaled SVGs: the Image implementation was erroneous. If the data for an image at the zoom level of the file (usually 100) was already loaded, this data is scaled instead of loading the file in proper zoom anew (as required for SVGs). That's easy to fix with a PR I provided today, so I added a fix that PR:

Allow to test for loading image at zoom and fix faulty Win32 image load eclipse.platform.swt#1987

Michael5601 · 2025-04-04T07:43:34Z

You can ignore my previous comment. I found the issue for the wrongly scaled SVGs: the Image implementation was erroneous. If the data for an image at the zoom level of the file (usually 100) was already loaded, this data is scaled instead of loading the file in proper zoom anew (as required for SVGs). That's easy to fix with a PR I provided today, so I added a fix that PR:

Allow to test for loading image at zoom and fix faulty Win32 image load eclipse.platform.swt#1987

Thats great, thank you! :)
I wanted to try it out on monday and I knew it must have to do with the 100% scaling as in my setup I tested moving from a 125% scaled monitor to 175% and thus not getting the blurry images. But after your comment I was pretty sure this was why I could not reproduce it.

Michael5601 force-pushed the AllSVGsAdded branch from bbd6f40 to 1f803fe Compare December 20, 2024 13:28

Michael5601 mentioned this pull request Dec 20, 2024

Feature Proposal: Rasterization of SVGs at Runtime for Eclipse Icons #2593

Merged

Michael5601 force-pushed the AllSVGsAdded branch from 1f803fe to 1ee7d7c Compare December 20, 2024 14:48

Michael5601 force-pushed the AllSVGsAdded branch from 1ee7d7c to 2182008 Compare January 21, 2025 15:29

Michael5601 force-pushed the AllSVGsAdded branch from 2182008 to be4eed4 Compare February 6, 2025 17:04

Michael5601 force-pushed the AllSVGsAdded branch from be4eed4 to 8e7e6f4 Compare February 24, 2025 08:25

Michael5601 force-pushed the AllSVGsAdded branch from 8e7e6f4 to cf3e508 Compare March 10, 2025 08:30

Michael5601 force-pushed the AllSVGsAdded branch from cf3e508 to f92d029 Compare March 24, 2025 07:46

HeikoKlare force-pushed the AllSVGsAdded branch from f92d029 to ff6d35a Compare March 30, 2025 10:51

HeikoKlare reviewed Mar 30, 2025

View reviewed changes

HeikoKlare mentioned this pull request Mar 30, 2025

Add required capability for SVG support to org.eclipse.ui #2871

Closed

Michael5601 force-pushed the AllSVGsAdded branch 2 times, most recently from f8d657a to f513ec7 Compare March 31, 2025 12:49

Michael5601 force-pushed the AllSVGsAdded branch from f513ec7 to d127140 Compare April 1, 2025 08:33

This was referenced Apr 3, 2025

Add SVGs to org.eclipse.debug.ui eclipse-platform/eclipse.platform#1797

Merged

Allow to test for loading image at zoom and fix faulty Win32 image load eclipse-platform/eclipse.platform.swt#1987

Merged

Michael5601 force-pushed the AllSVGsAdded branch from d127140 to 6929b43 Compare April 7, 2025 08:24

Michael5601 marked this pull request as draft April 11, 2025 08:54

Michael5601 and others added 2 commits April 14, 2025 09:41

added all SVGs

d896937

Version bump(s) for 4.36 stream

f0639c6

Michael5601 force-pushed the AllSVGsAdded branch from 6929b43 to f0639c6 Compare April 14, 2025 07:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add all SVGs for Platform UI Icons #2643

Add all SVGs for Platform UI Icons #2643

Michael5601 commented Dec 20, 2024

HeikoKlare left a comment

github-actions bot commented Mar 30, 2025 •

edited

Loading

eclipse-platform-bot commented Mar 30, 2025

Michael5601 commented Mar 31, 2025 •

edited

Loading

HeikoKlare commented Apr 3, 2025

HeikoKlare commented Apr 3, 2025

Michael5601 commented Apr 4, 2025

Add all SVGs for Platform UI Icons #2643

Are you sure you want to change the base?

Add all SVGs for Platform UI Icons #2643

Conversation

Michael5601 commented Dec 20, 2024

HeikoKlare left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 30, 2025 • edited Loading

Test Results

eclipse-platform-bot commented Mar 30, 2025

Michael5601 commented Mar 31, 2025 • edited Loading

HeikoKlare commented Apr 3, 2025

HeikoKlare commented Apr 3, 2025

Michael5601 commented Apr 4, 2025

github-actions bot commented Mar 30, 2025 •

edited

Loading

Michael5601 commented Mar 31, 2025 •

edited

Loading