Feature/parametrization #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geier1993
requested review from
stefaniereuter,
dsarmany and
MircoValentiniECMWF
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #47 +/- ##
===========================================
+ Coverage 22.91% 23.09% +0.17%
===========================================
Files 292 296 +4
Lines 30582 30711 +129
Branches 1169 1176 +7
===========================================
+ Hits 7009 7092 +83
- Misses 23573 23619 +46 ☔ View full report in Codecov by Sentry. |
dsarmany
force-pushed
the
feature/parametrization
branch
from
84217bd to
55e5921
Compare
dsarmany
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows sending (static) global metadata at the beginning of the simulation - called parametrization.
Parametrization can be accessed explicitly or inherently through local metadata objects.
When specific key lookups are made on a metadata object and the key is not-existing, a lookup to the global parametrization is made and its value is copied to the local object.
There should be no side effects to existing, working models - due to the second lookup, there may be a measurable difference in computational performance.
The feature was initially planned to be used with ifs, by sending static IFS specific information at the beginning and performing mappings from IFS specific information through an action.