Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remote-stake flag to device #138

Closed
wants to merge 3 commits into from
Closed

feat: add remote-stake flag to device #138

wants to merge 3 commits into from

Conversation

PodTheCoder
Copy link
Contributor

Related to: #106

Enables the user to launch a device node without having a local wallet. (device token staking method)

@PodTheCoder PodTheCoder changed the title feat: add remoteStake flag to device feat: add remote-stake flag to device Jun 7, 2023
@PodTheCoder
Copy link
Contributor Author

@PodTheCoder
Copy link
Contributor Author

Example command:
edge device start --remote-stake=3ae300d968514c1f2489eb46881b129614da4fc8f63fc3e6b5813fa2d0fd7f4c

Requirements:

  1. The Docker volume edge-device-data is set. This is done automatically in my GUI during the Create & Display Device Token step.
  2. Device is assigned to a stake on https://wallet.xe.network/staking . Thanks again to @annybs for implementing Assign Device.

Copy link
Member

@annybs annybs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, without having tested it myself, this looks good - but I think this can be tightened up.

I've added some comments to specific lines, but more broadly, I am wondering whether it is strictly necessary to define a separate --remote-stake option when there is already a --stake option available that is not used by any of the device commands. You could substitute that without causing any conflicts, and refer to just "stake" rather than "remote stake" throughout code (and similarly, stake rather than remoteStake).

More urgently, this PR is based on & targets the wrong branch - see CONTRIBUTING.md > Target branch. You'll need to rebase this contribution onto develop and then PR to develop. After that is done, I'll be able to test it properly and (once approved) push it to testnet ahead of a formal mainnet release.

Thanks for another solid contribution!

@PodTheCoder PodTheCoder closed this by deleting the head repository Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants