Skip to content

Conversation

@insukcho
Copy link
Contributor

Fixing the wrong links

Summary

Fixing two wrong link with azure to aws

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

@insukcho insukcho requested a review from a team as a code owner November 28, 2025 17:20
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

✅ Vale Linting Results

No issues found on modified lines!

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are supposed to keep users on the same page since these sections are visibly there too. The current links and the suggested fixes send users to a different page, which looks strange to me, and if correct would make me question why do we have those sections after on the page :D
Thanks for finding them and attempting a fix.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it must be a bug, but using just the local anchor tags that Florent suggested resulted in switching to another page that also has the same anchor tags. I'm going to try using full explicit links to make this work as expected and stay on the same page.

@benironside
Copy link
Contributor

Tested the links in the preview and they're now working.

@benironside benironside enabled auto-merge (squash) December 1, 2025 22:56
@benironside benironside dismissed florent-leborgne’s stale review December 1, 2025 22:56

Dismissing Florent's review because I updated the links and tested them in the preview, and they're now working.

@benironside benironside merged commit 2a0fa0d into main Dec 1, 2025
8 checks passed
@benironside benironside deleted the insukcho-patch-2 branch December 1, 2025 23:03
insukcho added a commit that referenced this pull request Dec 1, 2025
As following the same principle below described in #4150:

> I think these are supposed to keep users on the same page since these sections are visibly there too. 

changing the link to the same doc rather than pointing the different page
florent-leborgne added a commit that referenced this pull request Dec 2, 2025
As following the same principle below described in
#4150:

> I think these are supposed to keep users on the same page since these
sections are visibly there too.

changing the link to the same doc rather than pointing the different
page

## Generative AI disclosure
<!--
To help us ensure compliance with the Elastic open source and
documentation guidelines, please answer the following:
-->
1. Did you use a generative AI (GenAI) tool to assist in creating this
contribution?
- [ ] Yes  
- [x] No  
<!--

---------

Co-authored-by: florent-leborgne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants