Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration/system] add use_performance_counters in system integration #12528

Closed
wants to merge 0 commits into from
Closed

[integration/system] add use_performance_counters in system integration #12528

wants to merge 0 commits into from

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Jan 30, 2025 •
edited
Loading

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2025-01-30 at 4 23 47 PM Screenshot 2025-01-30 at 4 23 43 PM

Sorry, something went wrong.

@VihasMakwana VihasMakwana added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jan 30, 2025
@VihasMakwana VihasMakwana self-assigned this Jan 30, 2025
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #21279 failed 5bf406cf45581f25828358b48b792854dcb8c731

cc @VihasMakwana

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
4.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@VihasMakwana VihasMakwana changed the title chore: add use_performance_counters in system integration [integration/system] add use_performance_counters in system integration Jan 30, 2025
@VihasMakwana VihasMakwana mentioned this pull request Jan 30, 2025
Closed
@andrewkroh andrewkroh added Integration:1password 1Password (Partner supported) Integration:abnormal_security Abnormal Security New Integration Issue or pull request for creating a new integration package. labels Feb 4, 2025
@VihasMakwana VihasMakwana mentioned this pull request Feb 5, 2025
Closed
@VihasMakwana
Copy link
Contributor Author

Closing in favor of #12620

@VihasMakwana VihasMakwana deleted the system-perf-counters branch February 6, 2025 22:04
@VihasMakwana VihasMakwana restored the system-perf-counters branch February 6, 2025 22:05
@VihasMakwana VihasMakwana deleted the system-perf-counters branch February 6, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VihasMakwana VihasMakwana

Labels
Integration:abnormal_security Abnormal Security Integration:system System Integration:1password 1Password (Partner supported) New Integration Issue or pull request for creating a new integration package. Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VihasMakwana @elasticmachine @andrewkroh