Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration/system] add use_performance_counters in system integration #12620

Closed
wants to merge 12 commits into from
Closed

[integration/system] add use_performance_counters in system integration #12620

wants to merge 12 commits into from

Conversation

VihasMakwana
Copy link
Contributor

Proposed commit message

Recently, we added the ability to use performance counters to collect CPU metrics on windows. Add that option in system integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

Screenshot 2025-01-30 at 4 23 47 PM Screenshot 2025-01-30 at 4 23 43 PM

qcorporation and others added 11 commits February 4, 2025 12:21
@qcorporation
remove files
ed31586
@taylor-swanson
Update Deployment and Devices integrations to ECS 8.17.0 (part 2) (el…
7e124c4 
…astic#12571)

Updates the following integrations to ECS 8.17.0:

- fortinet_fortiedr
- fortinet_fortigate
- fortinet_fortimail
- fortinet_fortimanager
- fortinet_fortiproxy
- goflow2
- hashicorp_vault
- imperva
- iptables
@taylor-swanson
Update Deployment and Devices integrations to ECS 8.17.0 (part 1) (el…
b8fa530 
…astic#12569)

Update the following integrations to ECS 8.17.0:
- arista_ngfw
- cef
- checkpoint
- cisco_aironet
- cisco_asa
- cisco_ftd
- cisco_ios
- cisco_ise
- cisco_nexus
- cisco_secure_email_gateway
- citrix_waf
@taylor-swanson
Update Deployment and Devices integrations to ECS 8.17.0 (part 3) (el…
60807db 
…astic#12572)

Updated the following integrations to ECS 8.17.0:
- juniper_srx
- modsecurity
- netflow
- osquery
- panw
- pfsense
- proxysg
@taylor-swanson
Update Deployment and Devices integrations to ECS 8.17.0 (part 4) (el…
35c6e66 
…astic#12574)

Updated the following integrations to ECS 8.17.0:
- qnap_nas
- snort
- sonicwall_firewall
- sophos
- squid
- stormshield
- suricata
- tcp
- udp
- watchguard_firebox
- zeek
@taylor-swanson
[snort] Fix time format using incorrect year specifier (elastic#12599)
67cbd45 
- The time format used "week-based-year" (Y) instead of "year-of-era" (y). The former
gives very different results when calculating the month and date, since it is week-based.
- Regenerated test files with updated dates.
@lucian-ioan
[MS365] [Subscriptions] Add Subscriptions data stream (elastic#12490)
7c7e061
@harnish-elastic
[O11y][System] Fix dashboard query in [Metrics System] Host overview (
561d4b7 
elastic#12612)

* Fix dashboard query in [Metrics System] Host overview

* update pr link
@shmsr
packages/openai: New package (elastic#12494)
fd8c7f8
@gpop63
bump package version (elastic#12614)
6122116
@VihasMakwana
chore: add use_performance_counters in system integration
808611f
@VihasMakwana VihasMakwana added Integration:system System Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] labels Feb 5, 2025
@VihasMakwana VihasMakwana self-assigned this Feb 5, 2025
@VihasMakwana VihasMakwana requested review from a team as code owners February 5, 2025 13:15
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@VihasMakwana VihasMakwana mentioned this pull request Feb 5, 2025
Closed
5 tasks
@pierrehilbert pierrehilbert added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] labels Feb 5, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link

elasticmachine commented Feb 5, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @VihasMakwana

@qcorporation qcorporation requested review from a team as code owners February 5, 2025 22:00
@VihasMakwana VihasMakwana deleted the perf-counters branch February 6, 2025 22:04
@VihasMakwana VihasMakwana restored the perf-counters branch February 6, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VihasMakwana VihasMakwana

Labels
Integration:system System Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@VihasMakwana @elasticmachine @pierrehilbert @qcorporation @taylor-swanson @lucian-ioan @harnish-elastic @shmsr @gpop63